diff options
author | hjk <hjk@qt.io> | 2019-08-02 18:06:29 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-08-22 11:05:04 +0000 |
commit | fb631cb2585ae0acafa7a7df0f295c236f7b36f8 (patch) | |
tree | ee33f85a5bf0b802a6c70e6188b33a14dfdecff4 /src/plugins/autotoolsprojectmanager | |
parent | 02707ecdad63f8997a03294ae29d9adc38d054f3 (diff) |
ProjectExplorer: Set up hack to funnel information to buildstep ctors
For now, store most of BuildInfo in the BuildConfiguration. This will
allow accessing it in the BuildStep ctors so the BuildSteps can
be fully setup without polishing afterwards (as currently done
in the main build steps of the three buildsystems, and Nim)
This in meant to be temporary to a large degree.
Change-Id: If6ade6052f4b96670995399ae97ef7d2313f632a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/autotoolsprojectmanager')
-rw-r--r-- | src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp | 10 | ||||
-rw-r--r-- | src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h | 3 |
2 files changed, 3 insertions, 10 deletions
diff --git a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp index a4dba21818..64f31d6642 100644 --- a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp +++ b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.cpp @@ -60,9 +60,9 @@ AutotoolsBuildConfiguration::AutotoolsBuildConfiguration(Target *parent, Core::I setConfigWidgetDisplayName(tr("Autotools Manager")); } -void AutotoolsBuildConfiguration::initialize(const BuildInfo &info) +void AutotoolsBuildConfiguration::initialize() { - BuildConfiguration::initialize(info); + BuildConfiguration::initialize(); BuildStepList *buildSteps = stepList(BUILDSTEPS_BUILD); @@ -111,11 +111,5 @@ QList<BuildInfo> AutotoolsBuildConfigurationFactory::availableBuilds return {info}; } -BuildConfiguration::BuildType AutotoolsBuildConfiguration::buildType() const -{ - // TODO: Should I return something different from Unknown? - return Unknown; -} - } // Internal } // AutotoolsProjectManager diff --git a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h index 13d23834c3..1b2bcf8021 100644 --- a/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h +++ b/src/plugins/autotoolsprojectmanager/autotoolsbuildconfiguration.h @@ -39,8 +39,7 @@ class AutotoolsBuildConfiguration : public ProjectExplorer::BuildConfiguration friend class ProjectExplorer::BuildConfigurationFactory; AutotoolsBuildConfiguration(ProjectExplorer::Target *parent, Core::Id id); - void initialize(const ProjectExplorer::BuildInfo &info) override; - BuildType buildType() const override; + void initialize() override; }; class AutotoolsBuildConfigurationFactory : public ProjectExplorer::BuildConfigurationFactory |