diff options
author | hjk <hjk@qt.io> | 2019-03-21 08:09:35 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2019-09-11 06:03:40 +0000 |
commit | e9d8ff21b06d4224765b293de828f2cd1485bf3b (patch) | |
tree | 8b0f13027ef806a7f772bb34e6c641c6011fe328 /src/plugins/beautifier | |
parent | be7c215dd74317e20199ec73e283ca54f4eac20c (diff) |
Remove unused QObject parent arguments on options pages
In the new plugin setup scheme they are data members of the
plugin pimpl and never use the parent.
Change-Id: I28fe150393e8159064dcfbd113ce0320af50fd58
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/beautifier')
4 files changed, 5 insertions, 10 deletions
diff --git a/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.cpp b/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.cpp index 6fb77fc7d0..01deb00b4d 100644 --- a/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.cpp +++ b/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.cpp @@ -39,11 +39,8 @@ namespace Beautifier { namespace Internal { namespace ArtisticStyle { -ArtisticStyleOptionsPageWidget::ArtisticStyleOptionsPageWidget(ArtisticStyleSettings *settings, - QWidget *parent) : - QWidget(parent), - ui(new Ui::ArtisticStyleOptionsPage), - m_settings(settings) +ArtisticStyleOptionsPageWidget::ArtisticStyleOptionsPageWidget(ArtisticStyleSettings *settings) + : ui(new Ui::ArtisticStyleOptionsPage), m_settings(settings) { ui->setupUi(this); ui->useHomeFile->setText(ui->useHomeFile->text().replace( diff --git a/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.h b/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.h index fe8f604dc3..e1e9141bcb 100644 --- a/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.h +++ b/src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.h @@ -43,8 +43,7 @@ class ArtisticStyleOptionsPageWidget : public QWidget Q_OBJECT public: - explicit ArtisticStyleOptionsPageWidget(ArtisticStyleSettings *settings, - QWidget *parent = nullptr); + explicit ArtisticStyleOptionsPageWidget(ArtisticStyleSettings *settings); ~ArtisticStyleOptionsPageWidget() override; void restore(); void apply(); diff --git a/src/plugins/beautifier/generaloptionspage.cpp b/src/plugins/beautifier/generaloptionspage.cpp index c2bec70740..ae832f0c98 100644 --- a/src/plugins/beautifier/generaloptionspage.cpp +++ b/src/plugins/beautifier/generaloptionspage.cpp @@ -37,8 +37,7 @@ namespace Beautifier { namespace Internal { GeneralOptionsPageWidget::GeneralOptionsPageWidget(const QSharedPointer<GeneralSettings> &settings, - const QStringList &toolIds, QWidget *parent) : - QWidget(parent), + const QStringList &toolIds) : ui(new Ui::GeneralOptionsPage), m_settings(settings) { diff --git a/src/plugins/beautifier/generaloptionspage.h b/src/plugins/beautifier/generaloptionspage.h index 61f7e84d77..b6335f68ad 100644 --- a/src/plugins/beautifier/generaloptionspage.h +++ b/src/plugins/beautifier/generaloptionspage.h @@ -44,7 +44,7 @@ class GeneralOptionsPageWidget : public QWidget public: explicit GeneralOptionsPageWidget(const QSharedPointer<GeneralSettings> &settings, - const QStringList &toolIds, QWidget *parent = nullptr); + const QStringList &toolIds); ~GeneralOptionsPageWidget() override; void restore(); void apply(bool *autoFormatChanged); |