diff options
author | Artem Sokolovskii <artem.sokolovskii@qt.io> | 2022-03-29 15:48:15 +0200 |
---|---|---|
committer | Artem Sokolovskii <artem.sokolovskii@qt.io> | 2022-03-30 16:32:08 +0000 |
commit | 059d20ed222b4c1b387268edd85fbe6713d9855c (patch) | |
tree | 915f31775fd7707795d56c840245eadca419917f /src/plugins/clangformat | |
parent | 974d37d58a0695952477d606fd63b6d06e2335ea (diff) |
ClangFormat: Fix unsaving properties for global settings
- Fixed behavior "Formatting mode" combobox settings isn't
saved after pressing "Ok" button when no one project is
open. Now it works as expected, settings save after press
"Ok" button.
- Added additional applying interface for ICodeStylePreferenceFactory
which allows pass-through apply call from dialog to the editor.
Note: it doesn't work with read-only code style profiles
Change-Id: If4f0c85e3105550db4ffd9860e94b678f0d9b386
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/clangformat')
-rw-r--r-- | src/plugins/clangformat/clangformatconfigwidget.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/plugins/clangformat/clangformatconfigwidget.cpp b/src/plugins/clangformat/clangformatconfigwidget.cpp index 617030cb0d..9d44fe1dcc 100644 --- a/src/plugins/clangformat/clangformatconfigwidget.cpp +++ b/src/plugins/clangformat/clangformatconfigwidget.cpp @@ -201,11 +201,6 @@ void ClangFormatConfigWidget::showCombobox() m_ui->indentingOrFormatting->insertItem(indentIndex(), tr("Indenting only")); m_ui->indentingOrFormatting->insertItem(formatIndex(), tr("Full formatting")); - connect(m_ui->indentingOrFormatting, QOverload<int>::of(&QComboBox::currentIndexChanged), this, [this](int) { - if (m_project) - apply(); - }); - if (ClangFormatSettings::instance().formatCodeInsteadOfIndent()) m_ui->indentingOrFormatting->setCurrentIndex(formatIndex()); else |