diff options
| author | Marco Bubke <marco.bubke@qt.io> | 2018-03-12 14:08:18 +0100 |
|---|---|---|
| committer | Marco Bubke <marco.bubke@qt.io> | 2018-03-26 13:39:36 +0000 |
| commit | 9c4bfbe20a14cd671c9a9200055807c09ad89f3d (patch) | |
| tree | d7f1516aadf64114cdccd4405008a56d5b12c0dd /src/plugins/clangrefactoring/projectpartproviderinterface.h | |
| parent | f1e02c0826f3baf0c77cefe63c996fee6002d4ae (diff) | |
Clang: Improve interfaces
The interfaces should never used to handle ownership. So it is now using
protected destructors. Copy operations are forbidden too.
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c35-a-base-class-destructor-should-be-either-public-and-virtual-or-protected-and-nonvirtual
Change-Id: Ib0b60a73a7ec130973b5cb0095cc5b2f10fa0758
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Diffstat (limited to 'src/plugins/clangrefactoring/projectpartproviderinterface.h')
| -rw-r--r-- | src/plugins/clangrefactoring/projectpartproviderinterface.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/plugins/clangrefactoring/projectpartproviderinterface.h b/src/plugins/clangrefactoring/projectpartproviderinterface.h index 87b3e0d5f1..e503303f9c 100644 --- a/src/plugins/clangrefactoring/projectpartproviderinterface.h +++ b/src/plugins/clangrefactoring/projectpartproviderinterface.h @@ -39,7 +39,6 @@ class ProjectPartProviderInterface { public: ProjectPartProviderInterface() = default; - virtual ~ProjectPartProviderInterface(); ProjectPartProviderInterface(const ProjectPartProviderInterface&) = delete; ProjectPartProviderInterface& operator=(const ProjectPartProviderInterface&) = delete; @@ -49,6 +48,9 @@ public: virtual CppTools::ProjectPart *projectPart(const QString &projectPartId) const = 0; virtual ClangBackEnd::V2::FileContainers generatedFiles() const = 0; + +protected: + ~ProjectPartProviderInterface() = default; }; } // namespace ClangRefactoring |