diff options
author | Marco Bubke <marco.bubke@qt.io> | 2019-03-13 15:09:30 +0100 |
---|---|---|
committer | Marco Bubke <marco.bubke@qt.io> | 2019-04-01 10:31:38 +0000 |
commit | 6effa1822bd9bd265504c5ac3fed3fa5281e169f (patch) | |
tree | 794897a4f1f31c6040b64910ad807a865b0af451 /src/plugins/clangrefactoring/refactoringprojectupdater.h | |
parent | 72494277490566a04cb03bfbc25936eaa996c3b1 (diff) |
Clang: Improve project part updating
The project part ids are now already created very early in the database.
This removes some checks because we can assume that an id already exists.
The project part are now completely persistent, so we can read them from
the database and compare them with new generated from a new creator
session. This should help to not recreate the same PCH again and again.
Task-number: QTCREATORBUG-21151
Change-Id: Iced818ff9f7431eaed3e37978087cc0a43b9afda
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Diffstat (limited to 'src/plugins/clangrefactoring/refactoringprojectupdater.h')
-rw-r--r-- | src/plugins/clangrefactoring/refactoringprojectupdater.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/plugins/clangrefactoring/refactoringprojectupdater.h b/src/plugins/clangrefactoring/refactoringprojectupdater.h index 8e2652cf23..a9559ef94e 100644 --- a/src/plugins/clangrefactoring/refactoringprojectupdater.h +++ b/src/plugins/clangrefactoring/refactoringprojectupdater.h @@ -39,18 +39,18 @@ public: RefactoringProjectUpdater(ClangBackEnd::ProjectManagementServerInterface &server, ClangPchManager::PchManagerClient &pchManagerClient, CppTools::CppModelManagerInterface &cppModelManager, - ClangBackEnd::FilePathCachingInterface &filePathCache) - : ClangPchManager::ProjectUpdater(server, filePathCache), - ClangPchManager::PchManagerNotifierInterface(pchManagerClient), - m_cppModelManager(cppModelManager) + ClangBackEnd::FilePathCachingInterface &filePathCache, + ClangBackEnd::ProjectPartsStorageInterface &projectPartsStorage) + : ClangPchManager::ProjectUpdater(server, filePathCache, projectPartsStorage) + , ClangPchManager::PchManagerNotifierInterface(pchManagerClient) + , m_cppModelManager(cppModelManager) { - } - void precompiledHeaderUpdated(const QString &projectPartId, + void precompiledHeaderUpdated(ClangBackEnd::ProjectPartId projectPartId, const QString &pchFilePath, long long lastModified) override; - void precompiledHeaderRemoved(const QString &projectPartId) override; + void precompiledHeaderRemoved(ClangBackEnd::ProjectPartId projectPartId) override; private: CppTools::CppModelManagerInterface &m_cppModelManager; |