diff options
author | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2019-10-21 14:59:57 +0200 |
---|---|---|
committer | Nikolai Kosjar <nikolai.kosjar@qt.io> | 2019-12-03 13:23:13 +0000 |
commit | 0d7a30cdfe3f9611ce0653c556cc5a8d673ee061 (patch) | |
tree | 0b31979ff544e9e4e95fbb08d5593f9a46f824bf /src/plugins/clangtools/clangtidyclazyrunner.cpp | |
parent | 9a7f5e08fd170e032c726b55f26908d4fc2a7b96 (diff) |
ClangTools: Query the tools for supported checks
...instead of hardcoding them for a particular version of
clang-tidy/clazy.
While at it, move also the tidy/clazy widgets to ClangTools as this
simplifies feeding data to them.
Reduce also the built-in configs to a single one using clang-tidy's and
clazy's default checks as they look very reasonable and saves us some
porting effort. Also, our previous built-in configs were just too
numerous.
Change-Id: Ib9297acb7810a940b86a23a8695530506a570394
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Diffstat (limited to 'src/plugins/clangtools/clangtidyclazyrunner.cpp')
-rw-r--r-- | src/plugins/clangtools/clangtidyclazyrunner.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/plugins/clangtools/clangtidyclazyrunner.cpp b/src/plugins/clangtools/clangtidyclazyrunner.cpp index 34a149c823..cd8af27e85 100644 --- a/src/plugins/clangtools/clangtidyclazyrunner.cpp +++ b/src/plugins/clangtools/clangtidyclazyrunner.cpp @@ -75,11 +75,11 @@ static QStringList clazyPluginArguments(const ClangDiagnosticConfig diagnosticCo static QStringList tidyChecksArguments(const ClangDiagnosticConfig diagnosticConfig) { const ClangDiagnosticConfig::TidyMode tidyMode = diagnosticConfig.clangTidyMode(); - if (tidyMode != ClangDiagnosticConfig::TidyMode::Disabled) { - if (tidyMode != ClangDiagnosticConfig::TidyMode::File) - return {"-checks=" + diagnosticConfig.clangTidyChecks()}; - } - + // The argument "-config={}" stops stating/evaluating the .clang-tidy file. + if (tidyMode == ClangDiagnosticConfig::TidyMode::Default) + return {"-config={}"}; + if (tidyMode == ClangDiagnosticConfig::TidyMode::ChecksPrefixList) + return {"-config={}", "-checks=" + diagnosticConfig.clangTidyChecks()}; return {}; } |