diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2020-06-02 09:10:40 +0200 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2020-06-02 11:44:53 +0000 |
| commit | 5b364de1685e5bee5953e23da2552b5db4455a74 (patch) | |
| tree | 13f505553880048143feea6678dbd09e31558599 /src/plugins/clangtools | |
| parent | 26d46fc19dccb3b599dcd24f2a3701b7c4e25d2b (diff) | |
Use dialogParent() instead of mainWindow()
There are very few reasons to use mainWindow() directly.
Especially for modal dialogs, using dialogParent() is important, since
that guarantees the stacking order in case of other dialogs currently
being open.
Change-Id: I7ad2c23c5034b43195eb35cfe405932a7ea003e6
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/clangtools')
| -rw-r--r-- | src/plugins/clangtools/clangtool.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/clangtools/clangtool.cpp b/src/plugins/clangtools/clangtool.cpp index d96bdfd40f..6cc636dd87 100644 --- a/src/plugins/clangtools/clangtool.cpp +++ b/src/plugins/clangtools/clangtool.cpp @@ -639,7 +639,7 @@ static bool continueDespiteReleaseBuild(const QString &toolName) "<p>%2</p>" "</body></html>") .arg(problem, question); - return CheckableMessageBox::doNotAskAgainQuestion(ICore::mainWindow(), + return CheckableMessageBox::doNotAskAgainQuestion(ICore::dialogParent(), title, message, ICore::settings(), @@ -791,7 +791,7 @@ void ClangTool::loadDiagnosticsFromFiles() { // Ask user for files const QStringList filePaths - = QFileDialog::getOpenFileNames(Core::ICore::mainWindow(), + = QFileDialog::getOpenFileNames(Core::ICore::dialogParent(), tr("Select YAML Files with Diagnostics"), QDir::homePath(), tr("YAML Files (*.yml *.yaml);;All Files (*)")); |