diff options
author | Friedemann Kleint <Friedemann.Kleint@digia.com> | 2013-03-08 09:53:02 +0100 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@digia.com> | 2013-03-08 13:38:12 +0100 |
commit | cd7fdf7a4ae6db44907782790d9ca31f0140f7a5 (patch) | |
tree | 12b3929ac1acc2a7676ad85e4b8a05bc67ad2469 /src/plugins/clearcase/clearcasesync.cpp | |
parent | 07ea5346bc464c4d6c51abfe204d193b32b8999e (diff) |
Fix Krazy-warnings in ClearCase-plugin.
- non-const ref iterator
- values or keys iteration
Change-Id: If04abcafbeb8d5d143097ae66589b6f18bd7e28d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/clearcase/clearcasesync.cpp')
-rw-r--r-- | src/plugins/clearcase/clearcasesync.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/clearcase/clearcasesync.cpp b/src/plugins/clearcase/clearcasesync.cpp index a65dfd6b72..6ed60c63ae 100644 --- a/src/plugins/clearcase/clearcasesync.cpp +++ b/src/plugins/clearcase/clearcasesync.cpp @@ -75,12 +75,12 @@ void ClearCaseSync::run(QFutureInterface<void> &future, const QString &topLevel, if (hot) { // find all files whose permissions changed OR hijacked files // (might have become checked out) - foreach (const QString &file, m_statusMap->keys()) { - bool permChanged = - m_statusMap->value(file).permissions != QFileInfo(topLevel, file).permissions(); - if (permChanged || m_statusMap->value(file).status == FileStatus::Hijacked) { - files.append(file); - (*m_statusMap)[file].status = FileStatus::Unknown; + const StatusMap::Iterator send = m_statusMap->end(); + for (StatusMap::Iterator it = m_statusMap->begin(); it != send; ++it) { + const bool permChanged = it.value().permissions != QFileInfo(topLevel, it.key()).permissions(); + if (permChanged || it.value().status == FileStatus::Hijacked) { + files.append(it.key()); + it.value().status = FileStatus::Unknown; ++total; } } |