diff options
| author | hjk <hjk@qt.io> | 2020-01-09 17:32:51 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2020-01-10 12:46:38 +0000 |
| commit | 1eaf44a270dbc8ed3fb6aab24c7d267510acfd84 (patch) | |
| tree | 60136b971fe2705d7008007965a0e0ed086e4468 /src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp | |
| parent | 675c414b0799f6bed356d77f9f114578b19bfea7 (diff) | |
ProjectExplorer: De-QObject-ify BuildConfigurationFactories
The QObject was not heavily used. Object name was for debugging only,
translation context can be taken from the corresponding BuildConfiguration
objects, the qobject_casts in the three big importers are replaced by
dynamic_cast, which is good enough in that context.
Take the opportunity to re-use translations from base BuildConfiguration
for the common cases and sprinkle in some 'final'.
Change-Id: I8e9727c98c6e943cb333556861c24e701c2bdf45
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp')
| -rw-r--r-- | src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp b/src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp index 00302f6d35..1cda2387f4 100644 --- a/src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp +++ b/src/plugins/cmakeprojectmanager/cmakeprojectimporter.cpp @@ -338,7 +338,7 @@ Kit *CMakeProjectImporter::createKit(void *directoryData) const const QList<BuildInfo> CMakeProjectImporter::buildInfoListForKit(const Kit *k, void *directoryData) const { auto data = static_cast<const DirectoryData *>(directoryData); - auto factory = qobject_cast<CMakeBuildConfigurationFactory *>( + auto factory = dynamic_cast<CMakeBuildConfigurationFactory *>( BuildConfigurationFactory::find(k, projectFilePath())); if (!factory) return {}; |