diff options
author | hjk <hjk@qt.io> | 2020-08-25 02:33:43 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-08-25 14:19:04 +0000 |
commit | 6c785c05abf279e70a171acd2f7869f1f44c7685 (patch) | |
tree | da14e89b4ff0fadff1bfbe7e9a27110cd39388bb /src/plugins/cmakeprojectmanager | |
parent | 4b98cadb3a4767e80ff7be4c43eb0131f11332e6 (diff) |
ProjectExplorer: Remove ProcessParameters::resolveAll()
On all code paths, this was implicit in a ProcessParameters::setCommandLine()
which was on all code paths either called directly immediately before, or as
part of ProcessStep::setupProcessParameters().
With ProcessParameters::setCommandLine() as only user, this could be
inlined there. The effectiveWorkingDirectory() turned out to be out of
place and rather accidentally working there and was moved to
ProcessParameters::setWorkingDirectory().
Change-Id: I634f6086c2324e3cbecd3e5d50e22afc722abd3f
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/cmakeprojectmanager')
-rw-r--r-- | src/plugins/cmakeprojectmanager/cmakebuildstep.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp index c8428ee278b..9b143e0c191 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildstep.cpp @@ -250,7 +250,6 @@ bool CMakeBuildStep::init() ProcessParameters *pp = processParameters(); setupProcessParameters(pp); pp->setCommandLine(cmakeCommand(rc)); - pp->resolveAll(); return AbstractProcessStep::init(); } |