aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/cmakeprojectmanager
diff options
context:
space:
mode:
authorEike Ziller <eike.ziller@qt.io>2020-08-13 11:41:32 +0200
committerEike Ziller <eike.ziller@qt.io>2020-08-13 11:41:32 +0200
commitf296ed1328b9d12851b0474c6121fbbfba1f9b97 (patch)
tree23b05a9741b219a3ca4c1b2a3c3f45b4be34d82b /src/plugins/cmakeprojectmanager
parent96474eecc7ac3cdab7f1f3772de8181f1702bc39 (diff)
parent3e1d204c32fa735e599840afe166517fa0f90839 (diff)
Merge remote-tracking branch 'origin/4.13' into master
Diffstat (limited to 'src/plugins/cmakeprojectmanager')
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp18
-rw-r--r--src/plugins/cmakeprojectmanager/cmakebuildsystem.h2
2 files changed, 9 insertions, 11 deletions
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
index 6a55730d50c..f681a83d060 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
+++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
@@ -195,10 +195,7 @@ CMakeBuildSystem::CMakeBuildSystem(CMakeBuildConfiguration *bc)
connect(&m_reader, &FileApiReader::errorOccurred, this, &CMakeBuildSystem::handleParsingFailed);
connect(&m_reader, &FileApiReader::dirty, this, &CMakeBuildSystem::becameDirty);
- connect(SessionManager::instance(),
- &SessionManager::projectAdded,
- this,
- &CMakeBuildSystem::wireUpConnections);
+ wireUpConnections();
}
CMakeBuildSystem::~CMakeBuildSystem()
@@ -712,13 +709,8 @@ void CMakeBuildSystem::handleParsingFailed(const QString &msg)
combineScanAndParse();
}
-void CMakeBuildSystem::wireUpConnections(const Project *p)
+void CMakeBuildSystem::wireUpConnections()
{
- if (p != project())
- return; // That's not us...
-
- disconnect(SessionManager::instance(), nullptr, this, nullptr);
-
// At this point the entire project will be fully configured, so let's connect everything and
// trigger an initial parser run
@@ -740,6 +732,12 @@ void CMakeBuildSystem::wireUpConnections(const Project *p)
setParametersAndRequestParse(BuildDirParameters(cmakeBuildConfiguration()),
CMakeBuildSystem::REPARSE_DEFAULT);
});
+ connect(project(), &Project::activeTargetChanged, this, [this]() {
+ // Build configuration has changed:
+ qCDebug(cmakeBuildSystemLog) << "Requesting parse due to active target changed";
+ setParametersAndRequestParse(BuildDirParameters(cmakeBuildConfiguration()),
+ CMakeBuildSystem::REPARSE_DEFAULT);
+ });
// BuildConfiguration changed:
connect(cmakeBuildConfiguration(), &CMakeBuildConfiguration::environmentChanged, this, [this]() {
diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.h b/src/plugins/cmakeprojectmanager/cmakebuildsystem.h
index 86d77d7a7d7..e4c69a7d3c1 100644
--- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.h
+++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.h
@@ -134,7 +134,7 @@ private:
void handleParsingSucceeded();
void handleParsingFailed(const QString &msg);
- void wireUpConnections(const ProjectExplorer::Project *p);
+ void wireUpConnections();
Utils::FilePath workDirectory(const BuildDirParameters &parameters);
void stopParsingAndClearState();