diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2023-06-21 15:12:46 +0200 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2023-06-26 06:57:46 +0000 |
| commit | dff9e1463bfebe803af0c696222b6eeb04857c26 (patch) | |
| tree | 71a130bb73c65d88c0e87fdd06d0f06495c6670c /src/plugins/coco | |
| parent | 27302694ab794d8437b6feac4095ad34fa43ed24 (diff) | |
Reduce usage of app_version header
Most information is available via Q(Core|Gui)Application.
Add an AppInfo structure for the things that are not.
This avoids that the information ends up duplicated and
hardcoded in the plugins, which is not needed or desired.
Change-Id: I4d565e75c42a7b8facafa90c27096ea49359215d
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Diffstat (limited to 'src/plugins/coco')
| -rw-r--r-- | src/plugins/coco/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | src/plugins/coco/coco.qbs | 2 | ||||
| -rw-r--r-- | src/plugins/coco/cocolanguageclient.cpp | 4 |
3 files changed, 2 insertions, 5 deletions
diff --git a/src/plugins/coco/CMakeLists.txt b/src/plugins/coco/CMakeLists.txt index 43f4fd7c4a3..20e5132fffb 100644 --- a/src/plugins/coco/CMakeLists.txt +++ b/src/plugins/coco/CMakeLists.txt @@ -1,5 +1,4 @@ add_qtc_plugin(Coco - PUBLIC_DEPENDS app_version PLUGIN_DEPENDS Core LanguageClient SOURCES cocolanguageclient.cpp cocolanguageclient.h diff --git a/src/plugins/coco/coco.qbs b/src/plugins/coco/coco.qbs index 3a771f27175..70a072c3196 100644 --- a/src/plugins/coco/coco.qbs +++ b/src/plugins/coco/coco.qbs @@ -7,8 +7,6 @@ QtcPlugin { Depends { name: "LanguageClient" } Depends { name: "TextEditor" } - Depends { name: "app_version_header" } - Depends { name: "Qt"; submodules: ["widgets"] } files: [ diff --git a/src/plugins/coco/cocolanguageclient.cpp b/src/plugins/coco/cocolanguageclient.cpp index 56f3d20ee2c..83089cb751b 100644 --- a/src/plugins/coco/cocolanguageclient.cpp +++ b/src/plugins/coco/cocolanguageclient.cpp @@ -3,7 +3,6 @@ #include "cocolanguageclient.h" -#include <app/app_version.h> #include <coreplugin/editormanager/editormanager.h> #include <languageclient/diagnosticmanager.h> #include <languageclient/languageclienthoverhandler.h> @@ -17,6 +16,7 @@ #include <texteditor/textmark.h> #include <utils/utilsicons.h> +#include <QGuiApplication> #include <QTextEdit> using namespace LanguageClient; @@ -52,7 +52,7 @@ CocoLanguageClient::CocoLanguageClient(const FilePath &coco, const FilePath &csm ClientInfo info; info.setName("CocoQtCreator"); - info.setVersion(Core::Constants::IDE_VERSION_DISPLAY); + info.setVersion(QGuiApplication::applicationDisplayName()); setClientInfo(info); initClientCapabilities(); |