diff options
| author | hjk <hjk@qt.io> | 2023-07-17 09:11:27 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2023-07-19 14:00:17 +0000 |
| commit | 2b7e8599c8ae363edde5c0f91efafd22e02f8c06 (patch) | |
| tree | 63438004b8ca73e982bdb44b2d1badb5905bd7c4 /src/plugins/cppcheck | |
| parent | d7461a380b19316b3ad6c79dd8c0011e266664d3 (diff) | |
CppCheck: Move widget creation for manual run closer to its use
Change-Id: I08d50f5e4534b8a58d374ae37bfd03dbd234a483
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/cppcheck')
| -rw-r--r-- | src/plugins/cppcheck/cppcheckmanualrundialog.cpp | 6 | ||||
| -rw-r--r-- | src/plugins/cppcheck/cppcheckmanualrundialog.h | 2 | ||||
| -rw-r--r-- | src/plugins/cppcheck/cppcheckplugin.cpp | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/cppcheck/cppcheckmanualrundialog.cpp b/src/plugins/cppcheck/cppcheckmanualrundialog.cpp index d38a424b6b1..35a057ccffd 100644 --- a/src/plugins/cppcheck/cppcheckmanualrundialog.cpp +++ b/src/plugins/cppcheck/cppcheckmanualrundialog.cpp @@ -10,6 +10,7 @@ #include <cppeditor/projectinfo.h> +#include <utils/layoutbuilder.h> #include <utils/qtcassert.h> #include <QBoxLayout> @@ -18,8 +19,7 @@ namespace Cppcheck::Internal { -ManualRunDialog::ManualRunDialog(QWidget *optionsWidget, - const ProjectExplorer::Project *project) +ManualRunDialog::ManualRunDialog(const ProjectExplorer::Project *project) : m_model(new ProjectExplorer::SelectableFilesFromDirModel(this)) { QTC_ASSERT(project, return ); @@ -52,6 +52,8 @@ ManualRunDialog::ManualRunDialog(QWidget *optionsWidget, analyzeButton->setEnabled(m_model->hasCheckedFiles()); }); + auto optionsWidget = settings().layouter()().emerge(); + auto layout = new QVBoxLayout(this); layout->addWidget(optionsWidget); layout->addWidget(view); diff --git a/src/plugins/cppcheck/cppcheckmanualrundialog.h b/src/plugins/cppcheck/cppcheckmanualrundialog.h index 460a85e75c4..76206578e34 100644 --- a/src/plugins/cppcheck/cppcheckmanualrundialog.h +++ b/src/plugins/cppcheck/cppcheckmanualrundialog.h @@ -20,7 +20,7 @@ namespace Cppcheck::Internal { class ManualRunDialog : public QDialog { public: - ManualRunDialog(QWidget *optionsWidget, const ProjectExplorer::Project *project); + explicit ManualRunDialog(const ProjectExplorer::Project *project); Utils::FilePaths filePaths() const; QSize sizeHint() const override; diff --git a/src/plugins/cppcheck/cppcheckplugin.cpp b/src/plugins/cppcheck/cppcheckplugin.cpp index f8096350293..261eb50b0a5 100644 --- a/src/plugins/cppcheck/cppcheckplugin.cpp +++ b/src/plugins/cppcheck/cppcheckplugin.cpp @@ -112,9 +112,7 @@ void CppcheckPluginPrivate::startManualRun() manualRunTool.updateOptions(); - auto optionsWidget = settings().layouter()().emerge(); - - ManualRunDialog dialog(optionsWidget, project); + ManualRunDialog dialog(project); if (dialog.exec() == ManualRunDialog::Rejected) return; |