diff options
author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2024-02-03 01:44:38 +0100 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2024-02-06 11:03:16 +0000 |
commit | b6a64800849e16e2710e0ab97edff03830ea6550 (patch) | |
tree | 4c8e064c96e04728cee9848dd92e0e73cc94bf8c /src/plugins/cppeditor/cppquickfixes.cpp | |
parent | a1cc8551cc051476eff121a7b10a2e6d8547b2de (diff) |
LookupContext: Replace QSharedPointer with std::shared_ptr
According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews
QSharedPointer impl is poor and it's going to be removed from Qt 7.
Change-Id: Ia7ec4b427c5971d6bd375659b291a9aad2ead253
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/cppeditor/cppquickfixes.cpp')
-rw-r--r-- | src/plugins/cppeditor/cppquickfixes.cpp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/plugins/cppeditor/cppquickfixes.cpp b/src/plugins/cppeditor/cppquickfixes.cpp index 5c40ad9ce8..74862772e5 100644 --- a/src/plugins/cppeditor/cppquickfixes.cpp +++ b/src/plugins/cppeditor/cppquickfixes.cpp @@ -355,7 +355,7 @@ QString declFromExpr(const TypeOrExpr &typeOrExpr, const CallAST *call, const Na UseMinimalNames q(con); env.enter(&q); - Control *control = context.bindings()->control().data(); + Control *control = context.bindings()->control().get(); return rewriteType(result.first().type(), &env, control); }; @@ -580,7 +580,7 @@ namespace { class RewriteLogicalAndOp: public CppQuickFixOperation { public: - QSharedPointer<ASTPatternBuilder> mk; + std::shared_ptr<ASTPatternBuilder> mk; UnaryExpressionAST *left; UnaryExpressionAST *right; BinaryExpressionAST *pattern; @@ -1368,7 +1368,7 @@ void TranslateStringLiteral::doMatch(const CppQuickFixInterface &interface, QString trContext; - QSharedPointer<Control> control = interface.context().bindings()->control(); + std::shared_ptr<Control> control = interface.context().bindings()->control(); const Name *trName = control->identifier("tr"); // Check whether we are in a function: @@ -2768,7 +2768,7 @@ public: env.switchScope(decl->enclosingScope()); UseMinimalNames q(targetCoN); env.enter(&q); - Control *control = op->context().bindings()->control().data(); + Control *control = op->context().bindings()->control().get(); // rewrite the function type const FullySpecifiedType tn = rewriteType(decl->type(), &env, control); @@ -3625,7 +3625,7 @@ QString symbolAtDifferentLocation(const CppQuickFixInterface &interface, env.switchScope(symbol->enclosingScope()); UseMinimalNames q(cppCoN); env.enter(&q); - Control *control = interface.context().bindings()->control().data(); + Control *control = interface.context().bindings()->control().get(); Overview oo = CppCodeStyleSettings::currentProjectCodeStyleOverview(); return oo.prettyName(LookupContext::minimalName(symbol, cppCoN, control)); } @@ -3656,7 +3656,7 @@ FullySpecifiedType typeAtDifferentLocation(const CppQuickFixInterface &interface env.switchScope(originalScope); UseMinimalNames q(cppCoN); env.enter(&q); - Control *control = interface.context().bindings()->control().data(); + Control *control = interface.context().bindings()->control().get(); return rewriteType(type, &env, control); } @@ -5057,7 +5057,7 @@ public: env.enter(&subs); Overview printer = CppCodeStyleSettings::currentProjectCodeStyleOverview(); - Control *control = context().bindings()->control().data(); + Control *control = context().bindings()->control().get(); QString funcDef; QString funcDecl; // We generate a declaration only in the case of a member function. QString funcCall; @@ -6469,7 +6469,7 @@ QString definitionSignature(const CppQuickFixInterface *assist, env.switchScope(func->enclosingScope()); UseMinimalNames q(cppCoN); env.enter(&q); - Control *control = assist->context().bindings()->control().data(); + Control *control = assist->context().bindings()->control().get(); Overview oo = CppCodeStyleSettings::currentProjectCodeStyleOverview(); oo.showFunctionSignatures = true; oo.showReturnTypes = true; @@ -7066,7 +7066,7 @@ private: UseMinimalNames q(con); env.enter(&q); - Control *control = context().bindings()->control().data(); + Control *control = context().bindings()->control().get(); FullySpecifiedType type = rewriteType(result.first().type(), &env, control); return m_oo.prettyType(type, m_name); @@ -7775,7 +7775,7 @@ bool findConnectReplacement(const CppQuickFixInterface &interface, QTC_ASSERT(method, return false); // Minimize qualification - Control *control = context.bindings()->control().data(); + Control *control = context.bindings()->control().get(); ClassOrNamespace *functionCON = context.lookupParent(scope); const Name *shortName = LookupContext::minimalName(method, functionCON, control); if (!shortName->asQualifiedNameId()) |