ClangTools: Remove pointless "Disable" setting for clang-tidy

...as unchecking the root item in the tree has the same effect.

Change-Id: I960ea2c09a71dad3b0ba3dfb38a19055653354cd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>

1 files changed, 8 insertions, 4 deletions

diff --git a/src/plugins/cpptools/clangdiagnosticconfig.cpp b/src/plugins/cpptools/clangdiagnosticconfig.cpp
index 032d980316..51cf125366 100644
--- a/src/plugins/cpptools/clangdiagnosticconfig.cpp
+++ b/src/plugins/cpptools/clangdiagnosticconfig.cpp
@@ -190,10 +190,14 @@ ClangDiagnosticConfigs diagnosticConfigsFromSettings(QSettings *s)
         config.setId(Core::Id::fromSetting(s->value(diagnosticConfigIdKey)));
         config.setDisplayName(s->value(diagnosticConfigDisplayNameKey).toString());
         config.setClangOptions(s->value(diagnosticConfigWarningsKey).toStringList());
-        config.setClangTidyMode(static_cast<ClangDiagnosticConfig::TidyMode>(
-            s->value(diagnosticConfigsTidyModeKey).toInt()));
-        config.setClangTidyChecks(
-            s->value(diagnosticConfigsTidyChecksKey).toString());
+        const int tidyModeValue = s->value(diagnosticConfigsTidyModeKey).toInt();
+        if (tidyModeValue == 0) { // Convert from settings of <= Qt Creator 4.10
+            config.setClangTidyMode(ClangDiagnosticConfig::TidyMode::ChecksPrefixList);
+            config.setClangTidyChecks("-*");
+        } else {
+            config.setClangTidyMode(static_cast<ClangDiagnosticConfig::TidyMode>(tidyModeValue));
+            config.setClangTidyChecks(s->value(diagnosticConfigsTidyChecksKey).toString());
+        }
 
         config.setClazyMode(static_cast<ClangDiagnosticConfig::ClazyMode>(
             s->value(diagnosticConfigsClazyModeKey).toInt()));