diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-12-08 15:41:46 +0100 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2020-12-14 12:35:47 +0000 |
| commit | cf010911f7681b23aff6a150c50252374447addd (patch) | |
| tree | f1774eac8d9b3a8c66a00fe3b73163507660d20d /src/plugins/ctfvisualizer | |
| parent | 93dd966ce29720a295d01190f9b3f65e7d9043a8 (diff) | |
Don't allocate unneeded temporary containers
Fix clazy warnings: allocating an unneeded temporary container
[clazy-container-anti-pattern]
Change-Id: I4b4c2c634eea650bbdf3c12d982a17f899fc94ec
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/ctfvisualizer')
| -rw-r--r-- | src/plugins/ctfvisualizer/ctfstatisticsmodel.cpp | 4 | ||||
| -rw-r--r-- | src/plugins/ctfvisualizer/ctftracemanager.cpp | 11 |
2 files changed, 10 insertions, 5 deletions
diff --git a/src/plugins/ctfvisualizer/ctfstatisticsmodel.cpp b/src/plugins/ctfvisualizer/ctfstatisticsmodel.cpp index 8738d3d7476..1b997b2797e 100644 --- a/src/plugins/ctfvisualizer/ctfstatisticsmodel.cpp +++ b/src/plugins/ctfvisualizer/ctfstatisticsmodel.cpp @@ -83,7 +83,9 @@ QVariant CtfStatisticsModel::data(const QModelIndex &index, int role) const if (!index.isValid()) return QVariant(); - QString title = m_data.keys().at(index.row()); + auto it = m_data.cbegin(); + std::advance(it, index.row()); + const QString &title = it.key(); switch (role) { case Qt::TextAlignmentRole: diff --git a/src/plugins/ctfvisualizer/ctftracemanager.cpp b/src/plugins/ctfvisualizer/ctftracemanager.cpp index ba0976dbec5..651e6c6f8e3 100644 --- a/src/plugins/ctfvisualizer/ctftracemanager.cpp +++ b/src/plugins/ctfvisualizer/ctftracemanager.cpp @@ -176,8 +176,9 @@ void CtfTraceManager::load(const QString &filename) void CtfTraceManager::finalize() { bool userConsentToIgnoreDeepTraces = false; - for (qint64 tid: m_threadModels.keys()) { - if (m_threadModels[tid]->m_maxStackSize > 512) { + auto it = m_threadModels.begin(); + while (it != m_threadModels.end()) { + if (it.value()->m_maxStackSize > 512) { if (!userConsentToIgnoreDeepTraces) { QMessageBox::StandardButton answer = QMessageBox::question(Core::ICore::dialogParent(), @@ -192,8 +193,10 @@ void CtfTraceManager::finalize() break; } } - m_threadModels.remove(tid); - m_threadRestrictions.remove(tid); + m_threadRestrictions.remove(it.key()); + it = m_threadModels.erase(it); + } else { + ++it; } } for (CtfTimelineModel *model: m_threadModels) { |