Utils: Rename QtcProcess::Result::Finished to FinishedWithSuccess

To make clear that this is not just any finish.

Also change FinishedError to FinishedWithError, to create
symmetry.

Also adapt enum member description to reality.

Change-Id: I13e05391eb86fdb24e2ae660f14dfddb282e1104
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/plugins/cvs/cvsplugin.cpp b/src/plugins/cvs/cvsplugin.cpp
index 445b9378fac..2b8c5655534 100644
--- a/src/plugins/cvs/cvsplugin.cpp
+++ b/src/plugins/cvs/cvsplugin.cpp
@@ -204,8 +204,8 @@ public:
     {
         if (cmd == DiffCommand) {
             return [](int code) {
-                return (code < 0 || code > 2) ? QtcProcess::FinishedError
-                                              : QtcProcess::Finished;
+                return (code < 0 || code > 2) ? QtcProcess::FinishedWithError
+                                              : QtcProcess::FinishedWithSuccess;
             };
         }
         return {};
@@ -1458,10 +1458,10 @@ CvsResponse CvsPluginPrivate::runCvs(const QString &workingDirectory,
     response.stdErr = proc.stdErr();
     response.stdOut = proc.stdOut();
     switch (proc.result()) {
-    case QtcProcess::Finished:
+    case QtcProcess::FinishedWithSuccess:
         response.result = CvsResponse::Ok;
         break;
-    case QtcProcess::FinishedError:
+    case QtcProcess::FinishedWithError:
         response.result = CvsResponse::NonNullExitCode;
         break;
     case QtcProcess::TerminatedAbnormally: