aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/enginemanager.cpp
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2018-11-09 11:36:28 +0100
committerhjk <hjk@qt.io>2018-11-14 13:08:54 +0000
commit18e73a738be659bbc33306d800324a89c34b8f17 (patch)
treee7cdd5151b6b1c7086cb1f87dd07433b0b436a68 /src/plugins/debugger/enginemanager.cpp
parentdeef478b3823da3c832a66a15c5d19fce377f6bd (diff)
Debugger: Fix display of location marker when switching perspectives
Fixes: QTCREATORBUG-21362 Change-Id: I9bc1f0931ea902d04ab256774347b63c1fc64262 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/debugger/enginemanager.cpp')
-rw-r--r--src/plugins/debugger/enginemanager.cpp14
1 files changed, 3 insertions, 11 deletions
diff --git a/src/plugins/debugger/enginemanager.cpp b/src/plugins/debugger/enginemanager.cpp
index 9a14ffaa293..68f800c5b1e 100644
--- a/src/plugins/debugger/enginemanager.cpp
+++ b/src/plugins/debugger/enginemanager.cpp
@@ -337,7 +337,6 @@ void EngineManagerPrivate::activateEngineItem(EngineItem *engineItem)
if (DebuggerEngine *engine = m_currentItem->m_engine) {
newContext.add(engine->languageContext());
newContext.add(engine->debuggerContext());
- engine->gotoCurrentLocation();
} else {
newContext.add(Context(Constants::C_DEBUGGER_NOTRUNNING));
}
@@ -355,10 +354,8 @@ void EngineManagerPrivate::selectUiForCurrentEngine()
Perspective *perspective = nullptr;
int row = 0;
- if (m_currentItem && m_currentItem->m_engine) {
+ if (m_currentItem && m_currentItem->m_engine)
perspective = m_currentItem->m_engine->perspective();
- m_currentItem->m_engine->updateState(false);
- }
if (m_currentItem)
row = m_engineModel.rootItem()->indexOf(m_currentItem);
@@ -378,19 +375,14 @@ void EngineManagerPrivate::selectUiForCurrentEngine()
QTC_ASSERT(perspective, return);
perspective->select();
- m_engineModel.rootItem()->forFirstLevelChildren([](EngineItem *engineItem) {
+ m_engineModel.rootItem()->forFirstLevelChildren([this](EngineItem *engineItem) {
if (engineItem && engineItem->m_engine)
- engineItem->m_engine->updateMarkers();
+ engineItem->m_engine->updateUi(engineItem == m_currentItem);
});
emit theEngineManager->currentEngineChanged();
}
-void EngineManager::selectUiForCurrentEngine()
-{
- d->selectUiForCurrentEngine();
-}
-
EngineItem *EngineManagerPrivate::findEngineItem(DebuggerEngine *engine)
{
return m_engineModel.rootItem()->findFirstLevelChild([engine](EngineItem *engineItem) {