aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/debugger/stackwindow.h
diff options
context:
space:
mode:
authorAaron Barany <akb825@gmail.com>2018-12-11 23:09:39 -0800
committerAaron Barany <akb825@gmail.com>2019-01-08 18:43:44 +0000
commit21c0f5395ed163a122cc11de5f1ba8eb0805e25f (patch)
tree183db79686d0130fe557ce543bb3f08f24067b49 /src/plugins/debugger/stackwindow.h
parent6c40d9570cd0eb14f8e0651c51c730b8d19ebf14 (diff)
Debugger: Fix sizing of debugger columns
Added span column property to BaseTreeView. This takes an index to a column that will span remaining space not explicitly taken by the other columns. This listens to resizing of the tree view and columns that are manually resized to keep the sizes consistent. The stack view now once again uses the StackView class, which now sets the function column as the span column. This will adjust the column size the first time stack frame contents are encountered. It will not resize automatically until it's re-created (the next debug session) so it doesn't undo custom resizing. This also restores the ability to toggle stack addresses. Some obsolete parts of this class were removed as part of retrofitting it for the current state of the debugger. Stack, breakpoint, and thread views now resize remaining space for the function column rather than empty space at the end. This is generally the most important field when debugging and can get very long, especially in C++. Task-number: QTCREATORBUG-21763 Change-Id: I821c83d1d951f3311d7fa9fcddcbdeedfeed1573 Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/debugger/stackwindow.h')
-rw-r--r--src/plugins/debugger/stackwindow.h9
1 files changed, 4 insertions, 5 deletions
diff --git a/src/plugins/debugger/stackwindow.h b/src/plugins/debugger/stackwindow.h
index 5439ead73f..79f2974e82 100644
--- a/src/plugins/debugger/stackwindow.h
+++ b/src/plugins/debugger/stackwindow.h
@@ -34,17 +34,16 @@ namespace Internal {
class StackTreeView : public Utils::BaseTreeView
{
- Q_DECLARE_TR_FUNCTIONS(Debugger::Internal::StackTreeView)
-
public:
- StackTreeView();
+ explicit StackTreeView(QWidget *parent = nullptr);
private:
void setModel(QAbstractItemModel *model) override;
void showAddressColumn(bool on);
- void reloadFullStack();
- void copyContentsToClipboard();
+ void adjustForContents(bool refreshSpan = false);
+
+ bool m_contentsAdjusted = false;
};
} // namespace Internal