diff options
author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2018-04-06 15:57:30 +0200 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2018-04-09 09:31:40 +0000 |
commit | e806ea40ccaff89857604d53fc8e78a155ce9ad1 (patch) | |
tree | bcace8f44d4d9649a77c70e04b17736eb20a2a1d /src/plugins/diffeditor/descriptionwidgetwatcher.cpp | |
parent | 18ad5653d5cce51a02109e4955c1f4655d76b886 (diff) |
Pass this context object to the connect()
Otherwise when "this" instance
gets deleted and the sender still exists, the lambda
expression is still invoked for the deleted object.
Task-number: QTCREATORBUG-20223
Change-Id: Ifd5c9e6ce1fe7fde71698c6683cdfcd7566e8d35
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/diffeditor/descriptionwidgetwatcher.cpp')
-rw-r--r-- | src/plugins/diffeditor/descriptionwidgetwatcher.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/diffeditor/descriptionwidgetwatcher.cpp b/src/plugins/diffeditor/descriptionwidgetwatcher.cpp index 0e310cfbcd8..5b266ebe74a 100644 --- a/src/plugins/diffeditor/descriptionwidgetwatcher.cpp +++ b/src/plugins/diffeditor/descriptionwidgetwatcher.cpp @@ -44,7 +44,7 @@ DescriptionWidgetWatcher::DescriptionWidgetWatcher(DiffEditorController *control m_widgets.append(widget); } - connect(EditorManager::instance(), &EditorManager::editorOpened, + connect(EditorManager::instance(), &EditorManager::editorOpened, this, [this](IEditor *editor) { if (TextEditor::TextEditorWidget *widget = descriptionWidget(editor)) { m_widgets.append(widget); @@ -52,7 +52,7 @@ DescriptionWidgetWatcher::DescriptionWidgetWatcher(DiffEditorController *control } }); - connect(EditorManager::instance(), &EditorManager::editorAboutToClose, + connect(EditorManager::instance(), &EditorManager::editorAboutToClose, this, [this](IEditor *editor) { if (TextEditor::TextEditorWidget *widget = descriptionWidget(editor)) { emit descriptionWidgetRemoved(widget); |