diff options
| author | Christian Kandeler <christian.kandeler@digia.com> | 2014-07-01 11:08:26 +0200 |
|---|---|---|
| committer | hjk <hjk121@nokiamail.com> | 2014-07-01 11:52:08 +0200 |
| commit | 93304df0381cbeabf4c8435aec0ad55fbc7f8fe7 (patch) | |
| tree | 7cbe348b1e3f88041b7e159aa335031e2c41bfc8 /src/plugins/emacskeys | |
| parent | 139449239c7cd63ab933d13e20b37cd717a45fe7 (diff) | |
Always pass Core::Id by value.
Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.
Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <hjk121@nokiamail.com>
Diffstat (limited to 'src/plugins/emacskeys')
| -rw-r--r-- | src/plugins/emacskeys/emacskeysplugin.cpp | 2 | ||||
| -rw-r--r-- | src/plugins/emacskeys/emacskeysplugin.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/emacskeys/emacskeysplugin.cpp b/src/plugins/emacskeys/emacskeysplugin.cpp index 8793fe8710..fa55ecbaac 100644 --- a/src/plugins/emacskeys/emacskeysplugin.cpp +++ b/src/plugins/emacskeys/emacskeysplugin.cpp @@ -328,7 +328,7 @@ void EmacsKeysPlugin::insertLineAndIndent() m_currentState->endOwnAction(KeysActionOther); } -QAction *EmacsKeysPlugin::registerAction(const Core::Id &id, const char *slot, +QAction *EmacsKeysPlugin::registerAction(Core::Id id, const char *slot, const QString &title) { QAction *result = new QAction(title, this); diff --git a/src/plugins/emacskeys/emacskeysplugin.h b/src/plugins/emacskeys/emacskeysplugin.h index 716f70cf32..6eb8f2c963 100644 --- a/src/plugins/emacskeys/emacskeysplugin.h +++ b/src/plugins/emacskeys/emacskeysplugin.h @@ -94,7 +94,7 @@ private slots: void scrollHalfUp(); // M-v private: - QAction *registerAction(const Core::Id &id, const char *slot, + QAction *registerAction(Core::Id id, const char *slot, const QString &title); void genericGoto(QTextCursor::MoveOperation op, bool abortAssist = true); void genericVScroll(int direction); |