diff options
author | hjk <hjk@qt.io> | 2020-02-07 11:24:32 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-02-07 12:56:10 +0000 |
commit | eb1226df68edb2180425fda8411f57aab06c7b5f (patch) | |
tree | 83cab0eb431c1bf50efe9672da473f22caced496 /src/plugins/git/gitgrep.cpp | |
parent | 4e357e84c03c629a284c1f5505908f8a7644fba9 (diff) |
Git: Partially move plugin pimpl to .cpp
Same procedure as for ClearCase.
Unfortuately, some deep accesses are not easy to get rid of. Make them
available by static functions in the plugin itself. Definitely not the
favorite setup, but allows to proceed with the QObject removals.
Change-Id: Id85ed07bc7a6c1c053431a14dd7f68892f7ebea0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/git/gitgrep.cpp')
-rw-r--r-- | src/plugins/git/gitgrep.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/git/gitgrep.cpp b/src/plugins/git/gitgrep.cpp index 35fd7abc649..056903f855e 100644 --- a/src/plugins/git/gitgrep.cpp +++ b/src/plugins/git/gitgrep.cpp @@ -158,7 +158,7 @@ public: void exec() { - GitClient *client = GitPluginPrivate::client(); + GitClient *client = GitPlugin::client(); QStringList arguments = { "-c", "color.grep.match=bold red", "-c", "color.grep=always", @@ -248,7 +248,7 @@ GitGrep::GitGrep(QObject *parent) const QRegularExpression refExpression("[\\S]*"); m_treeLineEdit->setValidator(new QRegularExpressionValidator(refExpression, this)); layout->addWidget(m_treeLineEdit); - if (GitPluginPrivate::client()->gitVersion() >= 0x021300) { + if (GitPlugin::client()->gitVersion() >= 0x021300) { m_recurseSubmodules = new QCheckBox(tr("Recurse submodules")); layout->addWidget(m_recurseSubmodules); } @@ -320,7 +320,7 @@ IEditor *GitGrep::openEditor(const SearchResultItem &item, QByteArray content; const QString topLevel = parameters.additionalParameters.toString(); const QString relativePath = QDir(topLevel).relativeFilePath(path); - if (!GitPluginPrivate::client()->synchronousShow(topLevel, params.ref + ":./" + relativePath, + if (!GitPlugin::client()->synchronousShow(topLevel, params.ref + ":./" + relativePath, &content, nullptr)) { return nullptr; } |