aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/help/helpviewer.h
diff options
context:
space:
mode:
authorEike Ziller <eike.ziller@qt.io>2019-09-27 12:19:55 +0200
committerEike Ziller <eike.ziller@qt.io>2019-09-30 11:19:54 +0000
commitaad6ad8c10661d0a2da26871e65cfce052ea8897 (patch)
tree61e602bda67d0c93567cf79fee25cee94ccd0f3d /src/plugins/help/helpviewer.h
parentd34aee4d533304e3afacecf2ff0ae0d243fcd188 (diff)
Help: Replace annoying URL syncing by explicit Open in Edit Mode
Qt Creator was syncing the current page in Help mode to the page shown in the side-by-side view in edit mode. This doesn't really make sense because context is completely lost. Instead provide the explicit option to open a help page in edit mode, also from the external help window. Fixes: QTCREATORBUG-19198 Change-Id: I00698bb431d5c116dd1e0e1cbdc5fbd7421ac267 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: David Schulz <david.schulz@qt.io>
Diffstat (limited to 'src/plugins/help/helpviewer.h')
-rw-r--r--src/plugins/help/helpviewer.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/plugins/help/helpviewer.h b/src/plugins/help/helpviewer.h
index d502d7c664..b1be6e1dfb 100644
--- a/src/plugins/help/helpviewer.h
+++ b/src/plugins/help/helpviewer.h
@@ -63,8 +63,7 @@ public:
virtual QString title() const = 0;
virtual QUrl source() const = 0;
- // metacall in HelpPlugin::updateSideBarSource
- Q_INVOKABLE virtual void setSource(const QUrl &url) = 0;
+ virtual void setSource(const QUrl &url) = 0;
virtual void setHtml(const QString &html) = 0;