diff options
author | hjk <hjk@qt.io> | 2020-09-18 04:54:41 +0200 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-09-24 10:32:26 +0000 |
commit | 2cabd2ceb5ffc963acf2a9e2290973d3edde7087 (patch) | |
tree | 6e83d7924c698d1510a144ba88b7d5d74f1ee3cb /src/plugins/incredibuild | |
parent | 7bba76d0ffd9a063078b1e3ac8df6204f68985e4 (diff) |
Utils: Consolidate LayoutBuilder interface a bit
- the var args template for addItems was overkill creating a lot of
instantiations. Use a temporary list instead.
- allow default constructed LayoutItems to be used for an empty cell,
avoiding the use of a QLabel with empty text
- add an addRow({...}) overload as convenience shortcut for
.startNewRow().addItems({...}
- rename startNewRow() to finishRow()
Change-Id: I6d49dacbac3d7acf140ca526884ba1ceeeca2e0d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/incredibuild')
-rw-r--r-- | src/plugins/incredibuild/commandbuilderaspect.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/incredibuild/commandbuilderaspect.cpp b/src/plugins/incredibuild/commandbuilderaspect.cpp index 724e38d2ce..52353791a4 100644 --- a/src/plugins/incredibuild/commandbuilderaspect.cpp +++ b/src/plugins/incredibuild/commandbuilderaspect.cpp @@ -175,9 +175,9 @@ void CommandBuilderAspect::addToLayout(LayoutBuilder &builder) if (!d->m_loadedFromMap) d->tryToMigrate(); - builder.startNewRow().addItems(d->label.data(), d->commandBuilder.data()); - builder.startNewRow().addItems(tr("Make command:"), d->makePathChooser.data()); - builder.startNewRow().addItems(tr("Make arguments:"), d->makeArgumentsLineEdit.data()); + builder.addRow({d->label.data(), d->commandBuilder.data()}); + builder.addRow({tr("Make command:"), d->makePathChooser.data()}); + builder.addRow({tr("Make arguments:"), d->makeArgumentsLineEdit.data()}); updateGui(); } |