diff options
| author | hjk <hjk@qt.io> | 2020-06-19 15:52:29 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2020-06-19 14:03:03 +0000 |
| commit | b7862ae453cda0704432c9d3bc24afebae1e5680 (patch) | |
| tree | 017bceee3e5cd7d2ffa8c7dfa5e3b5febf44fa75 /src/plugins/languageclient | |
| parent | 8cb74f88f9a7680e6205e2cc3ed7407e02f49540 (diff) | |
LSP: Fix and simplify log size restriction logic
Do not subtract from unsigned (size) values.
Amends d15d15efa28eacf7bb85b91da72a612453be53de.
Change-Id: I9a8b09d3733b49ea646ae8a14caefcf5c908fad3
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'src/plugins/languageclient')
| -rw-r--r-- | src/plugins/languageclient/lsplogger.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/languageclient/lsplogger.cpp b/src/plugins/languageclient/lsplogger.cpp index 843809357c..923441d88e 100644 --- a/src/plugins/languageclient/lsplogger.cpp +++ b/src/plugins/languageclient/lsplogger.cpp @@ -94,10 +94,10 @@ void LspLogger::log(const LspLogMessage::MessageSender sender, const BaseMessage &message) { std::list<LspLogMessage> &clientLog = m_logs[clientName]; - for (auto delta = clientLog.size() - m_logSize + 1; delta > 0; --delta) + while (clientLog.size() >= m_logSize) clientLog.pop_front(); - m_logs[clientName].push_back({sender, QTime::currentTime(), message}); - emit newMessage(clientName, m_logs[clientName].back()); + clientLog.push_back({sender, QTime::currentTime(), message}); + emit newMessage(clientName, clientLog.back()); } std::list<LspLogMessage> LspLogger::messages(const QString &clientName) const |