diff options
author | hjk <hjk@qt.io> | 2020-01-15 14:32:19 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-01-17 09:20:31 +0000 |
commit | 43113470a45094d664a8580597d6e04c44a89e13 (patch) | |
tree | c4447dc5adfb731c65445d11db2668856933449e /src/plugins/perforce | |
parent | aac0f2a8f58f62f5b639b14301b56b57d1387a54 (diff) |
Vcs: Dissolve VcsBaseOptionsPage intermediate hierarchy level
It's effectively setting only three properties nowadays, not enough
to justify a case of reuse-by-inheritance anymore.
Change-Id: Ia0aedbd0dc460a70bed580a3402cf928c7221a77
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Diffstat (limited to 'src/plugins/perforce')
-rw-r--r-- | src/plugins/perforce/settingspage.cpp | 3 | ||||
-rw-r--r-- | src/plugins/perforce/settingspage.h | 6 |
2 files changed, 4 insertions, 5 deletions
diff --git a/src/plugins/perforce/settingspage.cpp b/src/plugins/perforce/settingspage.cpp index 933ea07b80..d8f15930f4 100644 --- a/src/plugins/perforce/settingspage.cpp +++ b/src/plugins/perforce/settingspage.cpp @@ -118,10 +118,11 @@ void SettingsPageWidget::setStatusError(const QString &t) } SettingsPage::SettingsPage(QObject *parent) - : VcsBaseOptionsPage(parent) + : Core::IOptionsPage(parent) { setId(VcsBase::Constants::VCS_ID_PERFORCE); setDisplayName(tr("Perforce")); + setCategory(VcsBase::Constants::VCS_SETTINGS_CATEGORY); } SettingsPage::~SettingsPage() diff --git a/src/plugins/perforce/settingspage.h b/src/plugins/perforce/settingspage.h index dbd5b64d7e..c3b5c6bb41 100644 --- a/src/plugins/perforce/settingspage.h +++ b/src/plugins/perforce/settingspage.h @@ -25,9 +25,7 @@ #pragma once -#include <QWidget> - -#include <vcsbase/vcsbaseoptionspage.h> +#include <coreplugin/dialogs/ioptionspage.h> #include "ui_settingspage.h" @@ -59,7 +57,7 @@ private: PerforceChecker *m_checker = nullptr; }; -class SettingsPage : public VcsBase::VcsBaseOptionsPage +class SettingsPage : public Core::IOptionsPage { Q_OBJECT |