Utils: Drop QProcess specific parameters from QtcProcess::finished()

Mid-term plan is to concentrate on use of QtcProcess::result()
instead which is a bit more system-agnostic.

There's quite a bit of potential for downstream cleanup by
re-using QtcProcess::exitMessage() now.

Change-Id: I3806b3f5933d96e64b7cfb18cc6c52823fddcbcd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

2 files changed, 5 insertions, 5 deletions

diff --git a/src/plugins/perforce/perforcechecker.cpp b/src/plugins/perforce/perforcechecker.cpp
index 620fb76fcd7..5cd3c57ca98 100644
--- a/src/plugins/perforce/perforcechecker.cpp
+++ b/src/plugins/perforce/perforcechecker.cpp
@@ -133,19 +133,19 @@ void PerforceChecker::slotError(QProcess::ProcessError error)
     }
 }
 
-void PerforceChecker::slotFinished(int exitCode, QProcess::ExitStatus exitStatus)
+void PerforceChecker::slotFinished()
 {
     if (m_timedOut)
         return;
-    switch (exitStatus) {
+    switch (m_process.exitStatus()) {
     case QProcess::CrashExit:
         emitFailed(tr("\"%1\" crashed.").arg(QDir::toNativeSeparators(m_binary)));
         break;
     case QProcess::NormalExit:
-        if (exitCode) {
+        if (m_process.exitCode()) {
             const QString stdErr = QString::fromLocal8Bit(m_process.readAllStandardError());
             emitFailed(tr("\"%1\" terminated with exit code %2: %3").
-                       arg(QDir::toNativeSeparators(m_binary)).arg(exitCode).arg(stdErr));
+                   arg(QDir::toNativeSeparators(m_binary)).arg(m_process.exitCode()).arg(stdErr));
         } else {
             parseOutput(QString::fromLocal8Bit(m_process.readAllStandardOutput()));
         }
diff --git a/src/plugins/perforce/perforcechecker.h b/src/plugins/perforce/perforcechecker.h
index c4d90d3009d..3232979390a 100644
--- a/src/plugins/perforce/perforcechecker.h
+++ b/src/plugins/perforce/perforcechecker.h
@@ -59,7 +59,7 @@ signals:
 
 private:
     void slotError(QProcess::ProcessError error);
-    void slotFinished(int exitCode, QProcess::ExitStatus exitStatus);
+    void slotFinished();
     void slotTimeOut();
 
     void emitFailed(const QString &);