Perfprofiler: Register settings aspects more directly

Change-Id: I19be173e4244add2d37eaab933293a6f30236c96
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

2 files changed, 6 insertions, 12 deletions

diff --git a/src/plugins/perfprofiler/perfsettings.cpp b/src/plugins/perfprofiler/perfsettings.cpp
index 9cfdf3d92c7..b7871b33cf9 100644
--- a/src/plugins/perfprofiler/perfsettings.cpp
+++ b/src/plugins/perfprofiler/perfsettings.cpp
@@ -25,19 +25,16 @@ PerfSettings::PerfSettings(ProjectExplorer::Target *target)
         return widget;
     });
 
-    registerAspect(&period);
     period.setSettingsKey("Analyzer.Perf.Frequency");
     period.setRange(250, 2147483647);
     period.setDefaultValue(250);
     period.setLabelText(Tr::tr("Sample period:"));
 
-    registerAspect(&stackSize);
     stackSize.setSettingsKey("Analyzer.Perf.StackSize");
     stackSize.setRange(4096, 65536);
     stackSize.setDefaultValue(4096);
     stackSize.setLabelText(Tr::tr("Stack snapshot size (kB):"));
 
-    registerAspect(&sampleMode);
     sampleMode.setSettingsKey("Analyzer.Perf.SampleMode");
     sampleMode.setDisplayStyle(SelectionAspect::DisplayStyle::ComboBox);
     sampleMode.setLabelText(Tr::tr("Sample mode:"));
@@ -45,7 +42,6 @@ PerfSettings::PerfSettings(ProjectExplorer::Target *target)
     sampleMode.addOption({Tr::tr("event count"), {}, QString("-c")});
     sampleMode.setDefaultValue(0);
 
-    registerAspect(&callgraphMode);
     callgraphMode.setSettingsKey("Analyzer.Perf.CallgraphMode");
     callgraphMode.setDisplayStyle(SelectionAspect::DisplayStyle::ComboBox);
     callgraphMode.setLabelText(Tr::tr("Call graph mode:"));
@@ -54,11 +50,9 @@ PerfSettings::PerfSettings(ProjectExplorer::Target *target)
     callgraphMode.addOption({Tr::tr("last branch record"), {}, QString("lbr")});
     callgraphMode.setDefaultValue(0);
 
-    registerAspect(&events);
     events.setSettingsKey("Analyzer.Perf.Events");
     events.setDefaultValue({"cpu-cycles"});
 
-    registerAspect(&extraArguments);
     extraArguments.setSettingsKey("Analyzer.Perf.ExtraArguments");
     extraArguments.setDisplayStyle(StringAspect::DisplayStyle::LineEditDisplay);
     extraArguments.setLabelText(Tr::tr("Additional arguments:"));
diff --git a/src/plugins/perfprofiler/perfsettings.h b/src/plugins/perfprofiler/perfsettings.h
index 4e8ae5700f8..cfa3de429ec 100644
--- a/src/plugins/perfprofiler/perfsettings.h
+++ b/src/plugins/perfprofiler/perfsettings.h
@@ -26,12 +26,12 @@ public:
 
     void resetToDefault();
 
-    Utils::IntegerAspect period;
-    Utils::IntegerAspect stackSize;
-    Utils::SelectionAspect sampleMode;
-    Utils::SelectionAspect callgraphMode;
-    Utils::StringListAspect events;
-    Utils::StringAspect extraArguments;
+    Utils::IntegerAspect period{this};
+    Utils::IntegerAspect stackSize{this};
+    Utils::SelectionAspect sampleMode{this};
+    Utils::SelectionAspect callgraphMode{this};
+    Utils::StringListAspect events{this};
+    Utils::StringAspect extraArguments{this};
 
 signals:
     void changed();