AbiWidget: Improve AbiWidget

Do less work in the Abi widget by ignoring intermediate states. Blocking signals
did not work well enough:-)

This makes the Abi widget more robust since a lot of useless state changes are
avoided. It also reduces the number of abiChanged signal emissions from this
widget, avoiding potentially costly updates in its users.

Change-Id: I777097a165502fade22f9ca3f154314c7362d655
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

1 files changed, 8 insertions, 5 deletions

diff --git a/src/plugins/projectexplorer/abiwidget.h b/src/plugins/projectexplorer/abiwidget.h
index dff42068fc9..569840bc1ff 100644
--- a/src/plugins/projectexplorer/abiwidget.h
+++ b/src/plugins/projectexplorer/abiwidget.h
@@ -46,7 +46,8 @@ public:
     AbiWidget(QWidget *parent = nullptr);
     ~AbiWidget() override;
 
-    void setAbis(const QList<Abi> &, const Abi &current);
+    void setAbis(const QList<Abi> &, const Abi &currentAbi);
+
     QList<Abi> supportedAbis() const;
     bool isCustomAbi() const;
     Abi currentAbi() const;
@@ -55,11 +56,13 @@ signals:
     void abiChanged();
 
 private:
-    void osChanged();
-    void modeChanged();
-    void updateCustomItemData();
+    void mainComboBoxChanged();
+    void customOsComboBoxChanged();
+    void customComboBoxesChanged();
+
+    void setCustomAbiComboBoxes(const Abi &current);
 
-    void setCustomAbi(const Abi &a);
+    void emitAbiChanged(const Abi &current);
 
     Internal::AbiWidgetPrivate *const d;
 };