diff options
author | Tobias Hunger <tobias.hunger@qt.io> | 2018-07-16 13:59:39 +0200 |
---|---|---|
committer | Tobias Hunger <tobias.hunger@qt.io> | 2018-07-24 09:04:54 +0000 |
commit | 80c2ce118d2e40a6b94117c46524c784d4737a52 (patch) | |
tree | 294ca26cbd2ae3c12b7f9d19923fbee07406848e /src/plugins/projectexplorer/jsonwizard | |
parent | 48850dfa4d47cd8ae6ac871a0438c9c164e073f5 (diff) |
ProjectExplorer: Modernize even more
Use unique_ptr for all *Private classes, except for those
in singletons.
Change-Id: Ib56c31ddedc6e9cf321f15de1f1e697a27ad4089
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Diffstat (limited to 'src/plugins/projectexplorer/jsonwizard')
-rw-r--r-- | src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp | 3 | ||||
-rw-r--r-- | src/plugins/projectexplorer/jsonwizard/jsonfieldpage.h | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp index a2e2cc0722..c4e3477596 100644 --- a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp +++ b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp @@ -139,14 +139,13 @@ private: // JsonFieldPage::FieldData: // -------------------------------------------------------------------- -JsonFieldPage::Field::Field() : d(new FieldPrivate) +JsonFieldPage::Field::Field() : d(std::make_unique<FieldPrivate>()) { } JsonFieldPage::Field::~Field() { delete d->m_widget; delete d->m_label; - delete d; } QString JsonFieldPage::Field::type() diff --git a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.h b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.h index 7cdb50c544..e1ddc7b559 100644 --- a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.h +++ b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.h @@ -33,6 +33,8 @@ #include <QRegularExpression> #include <QVariant> +#include <memory> + QT_BEGIN_NAMESPACE class QFormLayout; class QLabel; @@ -105,7 +107,7 @@ public: friend class JsonFieldPage; - FieldPrivate *const d; + const std::unique_ptr<FieldPrivate> d; }; JsonFieldPage(Utils::MacroExpander *expander, QWidget *parent = 0); |