aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/projectexplorer/outputparser_test.cpp
diff options
context:
space:
mode:
authorDaniel Teske <daniel.teske@theqtcompany.com>2015-04-20 17:13:45 +0200
committerDaniel Teske <daniel.teske@theqtcompany.com>2015-04-21 13:42:03 +0000
commit4f383f77b42fe6a0f7a2768b4c1103a68295ce3a (patch)
tree8fbdb53b3046be057b8c91b3dea65131997db048 /src/plugins/projectexplorer/outputparser_test.cpp
parent02068b8ef1d5dd615eb53478d01ff881cda73b74 (diff)
Tasks: Make the linking of compile output to Tasks more robust
Clicking on error messages is supposed to jump to the editor. And "Show Output" on the task is supposed to select the error in the output. The old code just registered the task for the last line of output. This broke for every parser that allowed for error messages that spanned multiple lines. And was obviously also incorrect for tasks that weren't generated due to compile output. Fix both of those issues by giving the IOutputParsers more control on which lines are linked to a task. Task-number: QTCREATORBUG-14136 Change-Id: I095922c9875620dabfb7d406f6b152c8a9b25b62 Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com> Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
Diffstat (limited to 'src/plugins/projectexplorer/outputparser_test.cpp')
-rw-r--r--src/plugins/projectexplorer/outputparser_test.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/plugins/projectexplorer/outputparser_test.cpp b/src/plugins/projectexplorer/outputparser_test.cpp
index bd5112f71a..f39a67f75d 100644
--- a/src/plugins/projectexplorer/outputparser_test.cpp
+++ b/src/plugins/projectexplorer/outputparser_test.cpp
@@ -142,8 +142,10 @@ void OutputParserTester::outputAdded(const QString &line, BuildStep::OutputForma
m_receivedOutput.append(line);
}
-void OutputParserTester::taskAdded(const Task &task)
+void OutputParserTester::taskAdded(const Task &task, int linkedLines, int skipLines)
{
+ Q_UNUSED(linkedLines);
+ Q_UNUSED(skipLines);
m_receivedTasks.append(task);
}