ProjectExplorer: Use full class for TriState value

Allows more compact code on the user side in most cases and
can hide the internal 'int-ness' from user code by wrapping
Variant conversions in the TriState class itself.

Change-Id: I4c91e0cd798ee988a0b9cb057749251a4efebaff
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 24 insertions, 3 deletions

diff --git a/src/plugins/projectexplorer/projectconfigurationaspects.h b/src/plugins/projectexplorer/projectconfigurationaspects.h
index 67d5a40e5c8..5d6977fa022 100644
--- a/src/plugins/projectexplorer/projectconfigurationaspects.h
+++ b/src/plugins/projectexplorer/projectconfigurationaspects.h
@@ -190,15 +190,36 @@ private:
     std::unique_ptr<Internal::BaseIntegerAspectPrivate> d;
 };
 
+class PROJECTEXPLORER_EXPORT TriState
+{
+    enum Value { EnabledValue, DisabledValue, DefaultValue };
+    explicit TriState(Value v) : m_value(v) {}
+
+public:
+    TriState() = default;
+
+    QVariant toVariant() const { return int(m_value); }
+    static TriState fromVariant(const QVariant &variant);
+
+    static const TriState Enabled;
+    static const TriState Disabled;
+    static const TriState Default;
+
+    friend bool operator==(TriState a, TriState b) { return a.m_value == b.m_value; }
+    friend bool operator!=(TriState a, TriState b) { return a.m_value != b.m_value; }
+
+private:
+    Value m_value = DefaultValue;
+};
+
 class PROJECTEXPLORER_EXPORT BaseTriStateAspect : public BaseSelectionAspect
 {
     Q_OBJECT
 public:
     BaseTriStateAspect();
 
-    enum class Value { Enabled, Disabled, Default };
-    Value setting() const;
-    void setSetting(Value setting);
+    TriState setting() const;
+    void setSetting(TriState setting);
 };
 
 } // namespace ProjectExplorer