diff options
| author | hjk <hjk@qt.io> | 2017-09-01 13:23:02 +0200 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2017-09-13 09:24:26 +0000 |
| commit | 890c1906e6fb2eceb3eaf381b0c298138be3a932 (patch) | |
| tree | b8497216ea125ac47621451082202a25000206e7 /src/plugins/projectexplorer/target.cpp | |
| parent | 4710e6b4b2df67a9d483c33e1a2b06a4139f7baa (diff) | |
ProjectExplorer: Re-organize RunConfiguration constructors
The idea is to massage the setup in a way to make implementation
of new configurations less error prone by identifying recurring patterns
and sharing repetitive code that tends to be forgotten (see Android cloning).
The former two lines of constructors (owner-and-id, owner-and-source)
are split into a simple, shared, constructor and new setId() and
copyFrom() functions.
The change is mostly mechanical, some multiple calls to fromMap
have been removed, though, some consts added.
Otherwise, to keep the patch small it temporarily introduces two
helper templates in IRunConfigurationFactory. Also, setId() signatures
have not been unified yet. These won't be needed in the final setup.
Change-Id: I8c0734496caae744a9883fe6d92c1d8f8e0234ea
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/projectexplorer/target.cpp')
| -rw-r--r-- | src/plugins/projectexplorer/target.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/plugins/projectexplorer/target.cpp b/src/plugins/projectexplorer/target.cpp index 90f4f5a515..221a8d55a2 100644 --- a/src/plugins/projectexplorer/target.cpp +++ b/src/plugins/projectexplorer/target.cpp @@ -115,9 +115,10 @@ QList<DeployConfigurationFactory *> TargetPrivate::deployFactories() const } Target::Target(Project *project, Kit *k) : - ProjectConfiguration(project, k->id()), + ProjectConfiguration(project), d(new TargetPrivate(k)) { + initialize(k->id()); QTC_CHECK(d->m_kit); connect(DeviceManager::instance(), &DeviceManager::updated, this, &Target::updateDeviceState); |