TargetSetupWidget: Avoid using sender()

Remove some unneeded Utils:: qualifiers.

Change-Id: I67e101545a6a614997fbd4d72eab97000afa9933
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>

1 files changed, 15 insertions, 19 deletions

diff --git a/src/plugins/projectexplorer/targetsetupwidget.cpp b/src/plugins/projectexplorer/targetsetupwidget.cpp
index 88c3a3540d..c2b486d1a0 100644
--- a/src/plugins/projectexplorer/targetsetupwidget.cpp
+++ b/src/plugins/projectexplorer/targetsetupwidget.cpp
@@ -65,13 +65,13 @@ TargetSetupWidget::TargetSetupWidget(Kit *k, const FilePath &projectPath) :
     auto vboxLayout = new QVBoxLayout();
     setLayout(vboxLayout);
     vboxLayout->setContentsMargins(0, 0, 0, 0);
-    m_detailsWidget = new Utils::DetailsWidget(this);
+    m_detailsWidget = new DetailsWidget(this);
     m_detailsWidget->setUseCheckBox(true);
     m_detailsWidget->setChecked(false);
     m_detailsWidget->setSummaryFontBold(true);
     vboxLayout->addWidget(m_detailsWidget);
 
-    auto panel = new Utils::FadingWidget(m_detailsWidget);
+    auto panel = new FadingWidget(m_detailsWidget);
     auto panelLayout = new QHBoxLayout(panel);
     m_manageButton = new QPushButton(KitAspectWidget::msgManage());
     panelLayout->addWidget(m_manageButton);
@@ -85,7 +85,7 @@ TargetSetupWidget::TargetSetupWidget(Kit *k, const FilePath &projectPath) :
     auto w = new QWidget;
     m_newBuildsLayout = new QGridLayout;
     m_newBuildsLayout->setContentsMargins(0, 0, 0, 0);
-    if (Utils::HostOsInfo::isMacHost())
+    if (HostOsInfo::isMacHost())
         m_newBuildsLayout->setSpacing(0);
     w->setLayout(m_newBuildsLayout);
     layout->addWidget(w);
@@ -95,9 +95,8 @@ TargetSetupWidget::TargetSetupWidget(Kit *k, const FilePath &projectPath) :
 
     setProjectPath(projectPath);
 
-    connect(m_detailsWidget, &Utils::DetailsWidget::checked,
+    connect(m_detailsWidget, &DetailsWidget::checked,
             this, &TargetSetupWidget::targetCheckBoxToggled);
-
     connect(m_manageButton, &QAbstractButton::clicked, this, &TargetSetupWidget::manageKit);
 }
 
@@ -157,8 +156,8 @@ void TargetSetupWidget::addBuildInfo(const BuildInfo &info, bool isImport)
         store.checkbox->setAttribute(Qt::WA_LayoutUsesWidgetRect);
         m_newBuildsLayout->addWidget(store.checkbox, pos * 2, 0);
 
-        store.pathChooser = new Utils::PathChooser();
-        store.pathChooser->setExpectedKind(Utils::PathChooser::Directory);
+        store.pathChooser = new PathChooser();
+        store.pathChooser->setExpectedKind(PathChooser::Directory);
         store.pathChooser->setFilePath(info.buildDirectory);
         store.pathChooser->setHistoryCompleter(QLatin1String("TargetSetup.BuildDir.History"));
         store.pathChooser->setReadOnly(isImport);
@@ -169,8 +168,10 @@ void TargetSetupWidget::addBuildInfo(const BuildInfo &info, bool isImport)
         m_newBuildsLayout->addWidget(store.issuesLabel, pos * 2 + 1, 0, 1, 2);
         store.issuesLabel->setVisible(false);
 
-        connect(store.checkbox, &QAbstractButton::toggled, this, &TargetSetupWidget::checkBoxToggled);
-        connect(store.pathChooser, &Utils::PathChooser::rawPathChanged, this, &TargetSetupWidget::pathChanged);
+        connect(store.checkbox, &QAbstractButton::toggled, this,
+                [this, checkBox = store.checkbox](bool b) { checkBoxToggled(checkBox, b); });
+        connect(store.pathChooser, &PathChooser::rawPathChanged, this,
+                [this, pathChooser = store.pathChooser] { pathChanged(pathChooser); });
     }
 
     store.hasIssues = false;
@@ -190,7 +191,7 @@ void TargetSetupWidget::targetCheckBoxToggled(bool b)
               || !contains(m_infoStore, &BuildInfoStore::isEnabled))) {
         m_detailsWidget->setState(DetailsWidget::Expanded);
     } else if (!b) {
-        m_detailsWidget->setState(Utils::DetailsWidget::Collapsed);
+        m_detailsWidget->setState(DetailsWidget::Collapsed);
     }
     emit selectedToggled();
 }
@@ -220,7 +221,7 @@ void TargetSetupWidget::setProjectPath(const FilePath &projectPath)
 
 void TargetSetupWidget::expandWidget()
 {
-    m_detailsWidget->setState(Utils::DetailsWidget::Expanded);
+    m_detailsWidget->setState(DetailsWidget::Expanded);
 }
 
 void TargetSetupWidget::update(const TasksGenerator &generator)
@@ -312,13 +313,10 @@ void TargetSetupWidget::updateDefaultBuildDirectories()
     }
 }
 
-void TargetSetupWidget::checkBoxToggled(bool b)
+void TargetSetupWidget::checkBoxToggled(QCheckBox *checkBox, bool b)
 {
-    auto box = qobject_cast<QCheckBox *>(sender());
-    if (!box)
-        return;
     auto it = std::find_if(m_infoStore.begin(), m_infoStore.end(),
-                           [box](const BuildInfoStore &store) { return store.checkbox == box; });
+              [checkBox](const BuildInfoStore &store) { return store.checkbox == checkBox; });
     QTC_ASSERT(it != m_infoStore.end(), return);
     if (it->isEnabled == b)
         return;
@@ -330,12 +328,10 @@ void TargetSetupWidget::checkBoxToggled(bool b)
     }
 }
 
-void TargetSetupWidget::pathChanged()
+void TargetSetupWidget::pathChanged(PathChooser *pathChooser)
 {
     if (m_ignoreChanges.isLocked())
         return;
-    auto pathChooser = qobject_cast<Utils::PathChooser *>(sender());
-    QTC_ASSERT(pathChooser, return);
 
     auto it = std::find_if(m_infoStore.begin(), m_infoStore.end(),
                            [pathChooser](const BuildInfoStore &store) {