ProjectExplorer: show kit warning in the wizard target setup page

Change-Id: I9aac268b902ed0a2dfd544811028affb480ed4d5
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

1 files changed, 8 insertions, 2 deletions

diff --git a/src/plugins/projectexplorer/targetsetupwidget.cpp b/src/plugins/projectexplorer/targetsetupwidget.cpp
index f851958b82..48a380f9be 100644
--- a/src/plugins/projectexplorer/targetsetupwidget.cpp
+++ b/src/plugins/projectexplorer/targetsetupwidget.cpp
@@ -208,7 +208,14 @@ void TargetSetupWidget::update(const TasksGenerator &generator)
     const Tasks tasks = generator(kit());
 
     m_detailsWidget->setSummaryText(kit()->displayName());
-    m_detailsWidget->setIcon(kit()->isValid() ? kit()->icon() : Icons::CRITICAL.icon());
+    if (!kit()->isValid())
+        m_detailsWidget->setIcon(Icons::CRITICAL.icon());
+    else if (kit()->hasWarning() || Utils::anyOf(tasks, Utils::equal(&Task::type, Task::Warning)))
+        m_detailsWidget->setIcon(Icons::WARNING.icon());
+    else
+        m_detailsWidget->setIcon(kit()->icon());
+
+    m_detailsWidget->setToolTip(kit()->toHtml(tasks, ""));
 
     const Task errorTask = Utils::findOrDefault(tasks, Utils::equal(&Task::type, Task::Error));
 
@@ -216,7 +223,6 @@ void TargetSetupWidget::update(const TasksGenerator &generator)
     // guarantee that we can handle the project sensibly (e.g. qmake project without Qt).
     if (!errorTask.isNull()) {
         toggleEnabled(false);
-        m_detailsWidget->setToolTip(kit()->toHtml(tasks, ""));
         m_infoStore.clear();
         return;
     }