Fix Krazy code scanning tool warnings (QString, loops, spelling).

4 files changed, 9 insertions, 8 deletions

diff --git a/src/plugins/projectexplorer/abi.cpp b/src/plugins/projectexplorer/abi.cpp
index f6b934abdf..903e65eef3 100644
--- a/src/plugins/projectexplorer/abi.cpp
+++ b/src/plugins/projectexplorer/abi.cpp
@@ -270,7 +270,7 @@ QString Abi::toString(const OSFlavor &of)
         return QLatin1String("msys");
     case ProjectExplorer::Abi::WindowsCEFlavor:
         return QLatin1String("ce");
-    case ProjectExplorer::Abi::UnknownFlavor: // fall throught!
+    case ProjectExplorer::Abi::UnknownFlavor: // fall through!
     default:
         return QLatin1String("unknown");
     }
diff --git a/src/plugins/projectexplorer/outputparser_test.cpp b/src/plugins/projectexplorer/outputparser_test.cpp
index 19e85c970c..9bbf21937d 100644
--- a/src/plugins/projectexplorer/outputparser_test.cpp
+++ b/src/plugins/projectexplorer/outputparser_test.cpp
@@ -171,10 +171,10 @@ void OutputParserTester::taskAdded(const ProjectExplorer::Task &task)
 
 void OutputParserTester::reset()
 {
-    m_receivedStdErrChildLine = QString();
-    m_receivedStdOutChildLine = QString();
+    m_receivedStdErrChildLine.clear();
+    m_receivedStdOutChildLine.clear();
     m_receivedTasks.clear();
-    m_receivedOutput = QString();
+    m_receivedOutput.clear();
 }
 
 #endif
diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp
index 75b4b17b4e..508e31ae0d 100644
--- a/src/plugins/projectexplorer/projectexplorer.cpp
+++ b/src/plugins/projectexplorer/projectexplorer.cpp
@@ -1353,7 +1353,8 @@ void ProjectExplorerPlugin::restoreSession()
     // Converts "filename" "+45" or "filename" ":23"
     // into     "filename+45"   and "filename:23"
     foreach (const QString &str, arguments) {
-        if (!combinedList.isEmpty() && (str.startsWith("+") || str.startsWith(":"))) {
+        if (!combinedList.isEmpty() && (str.startsWith(QLatin1Char('+'))
+                                        || str.startsWith(QLatin1Char(':')))) {
             combinedList.last().append(str);
         } else {
             combinedList << str;
@@ -2209,7 +2210,7 @@ QString ProjectExplorerPlugin::directoryFor(Node *node)
         // We figure out a commonPath from the subfolders
         QStringList list;
         foreach (FolderNode *f, folder->subFolderNodes())
-            list << f->path() + "/";
+            list << f->path() + QLatin1Char('/');
         if (list.isEmpty())
             location = path.left(path.indexOf('#'));
         else
@@ -2432,7 +2433,7 @@ void ProjectExplorerPlugin::renameFile(Node *node, const QString &to)
         return;
     QString orgFilePath = QFileInfo(node->path()).absoluteFilePath();
     QString dir = QFileInfo(orgFilePath).absolutePath();
-    QString newFilePath = dir + "/" + to;
+    QString newFilePath = dir + QLatin1Char('/') + to;
     Core::ICore *core = Core::ICore::instance();
     Core::IVersionControl *vc = core->vcsManager()->findVersionControlForDirectory(dir);
     bool result = false;
diff --git a/src/plugins/projectexplorer/targetselector.h b/src/plugins/projectexplorer/targetselector.h
index b637ade859..fd3a7f4f93 100644
--- a/src/plugins/projectexplorer/targetselector.h
+++ b/src/plugins/projectexplorer/targetselector.h
@@ -81,7 +81,7 @@ public slots:
 
 signals:
     void removeButtonClicked();
-    // This signal is emited whenever the target pointed to by the indices
+    // This signal is emitted whenever the target pointed to by the indices
     // has changed.
     void currentChanged(int targetIndex, int subIndex);