diff options
| author | hjk <hjk@qt.io> | 2017-11-20 11:56:19 +0100 |
|---|---|---|
| committer | hjk <hjk@qt.io> | 2017-11-27 07:23:17 +0000 |
| commit | 1697f97aff341dbd6b314702fd25ee16a54d6965 (patch) | |
| tree | 323cf32faee4b6e2e8df688a0f0f3a72a88903cf /src/plugins/qbsprojectmanager/qbsrunconfiguration.h | |
| parent | dbd365afe6f80d76f714f107dad31704f897b9e2 (diff) | |
ProjectExplorer: Register createes' base id in RunConfigurationFactory
This shifts the resposibility of creation/splitting of RunConfiguration
ids into what are essentially "type ids" and "build targets" to the base
implementation, possibly opening the path of abandoning the mangled ids
in favor of explicitly storing their constituent parts.
Take advantage of base id split in RunConfigurations for availableIds
/displayNameForId and for canCreate/canRestore/canClone.
Change-Id: I19fefb32757407ab5053a2ae0e5a79438659f6ec
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: Filippo Cucchetto <filippocucchetto@gmail.com>
Diffstat (limited to 'src/plugins/qbsprojectmanager/qbsrunconfiguration.h')
| -rw-r--r-- | src/plugins/qbsprojectmanager/qbsrunconfiguration.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/plugins/qbsprojectmanager/qbsrunconfiguration.h b/src/plugins/qbsprojectmanager/qbsrunconfiguration.h index 6f190fdd18..2d5ac1d263 100644 --- a/src/plugins/qbsprojectmanager/qbsrunconfiguration.h +++ b/src/plugins/qbsprojectmanager/qbsrunconfiguration.h @@ -108,12 +108,10 @@ class QbsRunConfigurationFactory : public ProjectExplorer::IRunConfigurationFact public: explicit QbsRunConfigurationFactory(QObject *parent = 0); - bool canCreate(ProjectExplorer::Target *parent, Core::Id id) const override; - bool canRestore(ProjectExplorer::Target *parent, const QVariantMap &map) const override; - bool canClone(ProjectExplorer::Target *parent, ProjectExplorer::RunConfiguration *source) const override; + bool canCreateHelper(ProjectExplorer::Target *parent, const QString &suffix) const override; - QList<Core::Id> availableCreationIds(ProjectExplorer::Target *parent, CreationMode mode) const override; - QString displayNameForId(Core::Id id) const override; + QList<QString> availableBuildTargets(ProjectExplorer::Target *parent, CreationMode mode) const override; + QString displayNameForBuildTarget(const QString &buildTarget) const override; }; } // namespace Internal |