diff options
author | Ulf Hermann <ulf.hermann@digia.com> | 2014-02-12 17:35:08 +0100 |
---|---|---|
committer | Ulf Hermann <ulf.hermann@digia.com> | 2014-02-18 14:43:52 +0100 |
commit | 47ce17b1ba82e396480c565dda6334fc58ed5cc3 (patch) | |
tree | 0eb79b6ce3801ef59b2b64555a89c13477a11068 /src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp | |
parent | 5d2654e4e4c6e4a2ca79ff9c6949e58472a9ae0f (diff) |
QmlProfiler: Sanitize the signal exchange between models a bit
The model manager should only set its state to 'Done' if all models are
actually done. When that is the case it can safely emit dataAvailable,
too, freeing us of the need to apply a heuristic to the progress
percentage. In order to have a unified interface to the completion of
model processing an abstract base class for QML and V8 models is
introduced.
Task-number: QTCREATORBUG-11466
Change-Id: Id89c7ef5e24004baab7f37ee5486b69e7611aee0
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
Diffstat (limited to 'src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp')
-rw-r--r-- | src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp b/src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp index bd2becee4cc..c6eb7f10380 100644 --- a/src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerstatewidget.cpp @@ -261,7 +261,7 @@ void QmlProfilerStateWidget::updateDisplay() void QmlProfilerStateWidget::dataStateChanged() { // consider possible rounding errors - d->loadingDone = d->m_modelManager->progress() >= 0.99 || + d->loadingDone = d->m_modelManager->state() == QmlProfilerDataState::Done || d->m_modelManager->state() == QmlProfilerDataState::Empty; d->traceAvailable = d->m_modelManager->traceTime()->duration() > 0; d->emptyList = d->m_modelManager->isEmpty() || d->m_modelManager->progress() == 0; |