aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/qmlprofiler
diff options
context:
space:
mode:
authorAlessandro Portale <alessandro.portale@qt.io>2020-11-27 13:12:23 +0100
committerAlessandro Portale <alessandro.portale@qt.io>2020-11-27 13:26:07 +0000
commita3857a996a6892a871f776452289a1520cff9337 (patch)
treed30d4e40002c29d13bb4421e244c113e59535007 /src/plugins/qmlprofiler
parent0cc5ee12c5b41dbe02af11dfd9c91410cf17362d (diff)
Don't access static functions/fields via instance
Courtesy of readability-static-accessed-through-instance Amends: b2a766a79ac778febff87f0def34cf6d3f4f93e3 Round #2: This time done with Qt Creator's Analyzer, which found other occurences than run-clang-tidy.py Change-Id: I479e280c7abcf2d24baccbb0af69ae4bda05198e Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'src/plugins/qmlprofiler')
-rw-r--r--src/plugins/qmlprofiler/tests/pixmapcachemodel_test.cpp6
-rw-r--r--src/plugins/qmlprofiler/tests/qmlprofilerattachdialog_test.cpp4
-rw-r--r--src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp2
3 files changed, 6 insertions, 6 deletions
diff --git a/src/plugins/qmlprofiler/tests/pixmapcachemodel_test.cpp b/src/plugins/qmlprofiler/tests/pixmapcachemodel_test.cpp
index f97c5991865..97b124e016c 100644
--- a/src/plugins/qmlprofiler/tests/pixmapcachemodel_test.cpp
+++ b/src/plugins/qmlprofiler/tests/pixmapcachemodel_test.cpp
@@ -255,10 +255,10 @@ void PixmapCacheModelTest::testConsistency()
break;
}
- QString filename = details[model.tr("File")].toString();
+ QString filename = details[PixmapCacheModel::tr("File")].toString();
QVERIFY(filename == QString("dings.png") || filename == QString("blah.png"));
- QVERIFY(details.contains(model.tr("Width")));
- QVERIFY(details.contains(model.tr("Height")));
+ QVERIFY(details.contains(PixmapCacheModel::tr("Width")));
+ QVERIFY(details.contains(PixmapCacheModel::tr("Height")));
}
}
diff --git a/src/plugins/qmlprofiler/tests/qmlprofilerattachdialog_test.cpp b/src/plugins/qmlprofiler/tests/qmlprofilerattachdialog_test.cpp
index d0a2856cd8c..628b8803c00 100644
--- a/src/plugins/qmlprofiler/tests/qmlprofilerattachdialog_test.cpp
+++ b/src/plugins/qmlprofiler/tests/qmlprofilerattachdialog_test.cpp
@@ -48,13 +48,13 @@ void QmlProfilerAttachDialogTest::testAccessors()
ProjectExplorer::KitManager *kitManager = ProjectExplorer::KitManager::instance();
QVERIFY(kitManager);
- ProjectExplorer::Kit * const newKit = kitManager->registerKit({}, "dings");
+ ProjectExplorer::Kit * const newKit = ProjectExplorer::KitManager::registerKit({}, "dings");
QVERIFY(newKit);
dialog.setKitId("dings");
QCOMPARE(dialog.kit(), newKit);
- kitManager->deregisterKit(newKit);
+ ProjectExplorer::KitManager::deregisterKit(newKit);
}
} // namespace Internal
diff --git a/src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp b/src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp
index ab085ea4586..bac99ccdbfe 100644
--- a/src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp
+++ b/src/plugins/qmlprofiler/tests/qmlprofilertool_test.cpp
@@ -46,7 +46,7 @@ void QmlProfilerToolTest::testAttachToWaitingApplication()
{
ProjectExplorer::KitManager *kitManager = ProjectExplorer::KitManager::instance();
QVERIFY(kitManager);
- ProjectExplorer::Kit * const newKit = kitManager->registerKit({}, "fookit");
+ ProjectExplorer::Kit * const newKit = ProjectExplorer::KitManager::registerKit({}, "fookit");
QVERIFY(newKit);
QSettings *settings = Core::ICore::settings();
QVERIFY(settings);