diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2019-11-28 13:41:06 +0100 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2019-11-28 13:36:31 +0000 |
| commit | 1492284241e2b4a46ac07dab9391f18df3c0d8e6 (patch) | |
| tree | 8895bf52860ad50ca0f823ed2d9d8d4bbbcfc8d0 /src/plugins/qtsupport/qtbuildaspects.cpp | |
| parent | e6e9f4017d9426f3bdd1f9ffee43edb2242a0ec1 (diff) | |
Build aspects: Fix some UI glitches
Add missing colons, hide empty labels.
Change-Id: Ic9753044d8dc842105d89225df45978220b0d8da
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/qtsupport/qtbuildaspects.cpp')
| -rw-r--r-- | src/plugins/qtsupport/qtbuildaspects.cpp | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/plugins/qtsupport/qtbuildaspects.cpp b/src/plugins/qtsupport/qtbuildaspects.cpp index 16ffbe3978a..cc8c13168c2 100644 --- a/src/plugins/qtsupport/qtbuildaspects.cpp +++ b/src/plugins/qtsupport/qtbuildaspects.cpp @@ -41,7 +41,7 @@ namespace QtSupport { QmlDebuggingAspect::QmlDebuggingAspect() { setSettingsKey("EnableQmlDebugging"); - setDisplayName(tr("QML debugging and profiling")); + setDisplayName(tr("QML debugging and profiling:")); } void QmlDebuggingAspect::addToLayout(LayoutBuilder &builder) @@ -64,8 +64,9 @@ void QmlDebuggingAspect::addToLayout(LayoutBuilder &builder) } warningTextLabel->setText(warningText); setVisibleDynamic(supported); - warningIconLabel->setVisible(supported && !warningText.isEmpty()); - warningTextLabel->setVisible(supported); + const bool warningLabelsVisible = supported && !warningText.isEmpty(); + warningIconLabel->setVisible(warningLabelsVisible); + warningTextLabel->setVisible(warningLabelsVisible); }; connect(KitManager::instance(), &KitManager::kitsChanged, builder.layout(), changeHandler); connect(this, &QmlDebuggingAspect::changed, builder.layout(), changeHandler); @@ -75,7 +76,7 @@ void QmlDebuggingAspect::addToLayout(LayoutBuilder &builder) QtQuickCompilerAspect::QtQuickCompilerAspect() { setSettingsKey("QtQuickCompiler"); - setDisplayName(tr("Qt Quick Compiler")); + setDisplayName(tr("Qt Quick Compiler:")); } void QtQuickCompilerAspect::addToLayout(LayoutBuilder &builder) @@ -99,8 +100,9 @@ void QtQuickCompilerAspect::addToLayout(LayoutBuilder &builder) } warningTextLabel->setText(warningText); setVisibleDynamic(supported); - warningIconLabel->setVisible(supported && !warningText.isEmpty()); - warningTextLabel->setVisible(supported); + const bool warningLabelsVisible = supported && !warningText.isEmpty(); + warningIconLabel->setVisible(warningLabelsVisible); + warningTextLabel->setVisible(warningLabelsVisible); }; connect(KitManager::instance(), &KitManager::kitsChanged, builder.layout(), changeHandler); connect(this, &QmlDebuggingAspect::changed, builder.layout(), changeHandler); |