diff options
author | hjk <hjk@qt.io> | 2020-01-10 14:20:32 +0100 |
---|---|---|
committer | hjk <hjk@qt.io> | 2020-01-14 09:04:49 +0000 |
commit | 5e7f99157b1face8da88e9df431408cf72a31961 (patch) | |
tree | 774c539a63f7bc77f2fdfb10f96be942184639c4 /src/plugins/qtsupport/qtoptionspage.h | |
parent | 5e4b10060fc86b6889d3b7a2ffe8f775382a7543 (diff) |
QtSupport: Move option widget decalaration in .cpp
Slimmer interface, allow removing m_ui indirections,
du -s .obj: 66684 -> 65868
Change-Id: I686745017a5d239f41e256fd28f595a1fc3b5bac
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Diffstat (limited to 'src/plugins/qtsupport/qtoptionspage.h')
-rw-r--r-- | src/plugins/qtsupport/qtoptionspage.h | 99 |
1 files changed, 4 insertions, 95 deletions
diff --git a/src/plugins/qtsupport/qtoptionspage.h b/src/plugins/qtsupport/qtoptionspage.h index 4d07b94aa4..e2bfc9cbef 100644 --- a/src/plugins/qtsupport/qtoptionspage.h +++ b/src/plugins/qtsupport/qtoptionspage.h @@ -27,107 +27,16 @@ #include <coreplugin/dialogs/ioptionspage.h> -#include <utils/fileutils.h> -#include <utils/treemodel.h> - -#include <QIcon> -#include <QWidget> - -QT_BEGIN_NAMESPACE -class QSortFilterProxyModel; -class QTextBrowser; -class QUrl; -QT_END_NAMESPACE - -namespace ProjectExplorer { class ToolChain; } - namespace QtSupport { - -class BaseQtVersion; -class QtConfigWidget; - namespace Internal { -class QtVersionItem; - -namespace Ui { -class QtVersionManager; -class QtVersionInfo; -} -class QtOptionsPageWidget : public Core::IOptionsPageWidget +class QtOptionsPage final : public Core::IOptionsPage { - Q_OBJECT - public: - QtOptionsPageWidget(); - ~QtOptionsPageWidget(); + QtOptionsPage(); static void linkWithQt(); - -private: - void apply() final; - void finish() final {} - - void updateDescriptionLabel(); - void userChangedCurrentVersion(); - void updateWidgets(); - void setupLinkWithQtButton(); - BaseQtVersion *currentVersion() const; - QtVersionItem *currentItem() const; - void showDebuggingBuildLog(const QtVersionItem *item); - - const QString m_specifyNameString; - - Internal::Ui::QtVersionManager *m_ui; - Internal::Ui::QtVersionInfo *m_versionUi; - QTextBrowser *m_infoBrowser; - int m_defaultVersion; - QIcon m_invalidVersionIcon; - QIcon m_warningVersionIcon; - QIcon m_validVersionIcon; - QtConfigWidget *m_configurationWidget; - -private: - void updateQtVersions(const QList<int> &, const QList<int> &, const QList<int> &); - void versionChanged(const QModelIndex ¤t, const QModelIndex &previous); - void addQtDir(); - void removeQtDir(); - void editPath(); - void updateCleanUpButton(); - void updateCurrentQtName(); - - void cleanUpQtVersions(); - void toolChainsUpdated(); - - void setInfoWidgetVisibility(); - void infoAnchorClicked(const QUrl &); - - struct ValidityInfo { - QString description; - QString message; - QString toolTip; - QIcon icon; - }; - ValidityInfo validInformation(const BaseQtVersion *version); - QList<ProjectExplorer::ToolChain*> toolChains(const BaseQtVersion *version); - QByteArray defaultToolChainId(const BaseQtVersion *version); - - bool isNameUnique(const BaseQtVersion *version); - void updateVersionItem(QtVersionItem *item); - - Utils::TreeModel<Utils::TreeItem, Utils::TreeItem, QtVersionItem> *m_model; - QSortFilterProxyModel *m_filterModel; - Utils::TreeItem *m_autoItem; - Utils::TreeItem *m_manualItem; -}; - -class QtOptionsPage : public Core::IOptionsPage -{ - Q_OBJECT - -public: - QtOptionsPage(); }; -} //namespace Internal -} //namespace QtSupport +} // Internal +} // QtSupport |