aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/qtsupport/qtversionfactory.h
diff options
context:
space:
mode:
authorhjk <hjk@qt.io>2017-12-08 17:20:48 +0100
committerhjk <hjk@qt.io>2017-12-15 07:08:05 +0000
commitcc883023090030eb341a11c4d6634ca027f02c65 (patch)
treef5dd463617c340842e1f74440f0caa3a8ea41d3b /src/plugins/qtsupport/qtversionfactory.h
parent32762e27e2f4556cd7ed63f78ed3f28695fddccf (diff)
De-emphasize PluginManager::getObjects<Type>()
... by additionally keeping local (currently non-owning) pools per "interesting" type. Current situation: - The global object pool does not scale well for looking up objects, as iteration plus qobject_cast typically iterates over all pooled objects. - User code that can use typed results from the object pool need to have access to the full type definition anyway, i.e. depend on the plugin of the target class anyway. The patch here solves the scaling problem is to have local type-specific pools to which objects register in their constructors and deregister in their destructors. This patch here does *not* change the ownership model of the pooled objects, however, it opens the possibility to change the ownership model per type (e.g. by not putting things into the global pool at all anymore and make the local pool 'owning') and the intent is to handle that in later patchs. Even without the follow-up patches this here is a performance improvement for the cases that access the local pools instead the global one, i.e. "practically all". Change-Id: Ib11a42df2c4ecf5e1155534730083a520dd1995b Reviewed-by: Eike Ziller <eike.ziller@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/plugins/qtsupport/qtversionfactory.h')
-rw-r--r--src/plugins/qtsupport/qtversionfactory.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/qtsupport/qtversionfactory.h b/src/plugins/qtsupport/qtversionfactory.h
index d789717408..c54b2c3745 100644
--- a/src/plugins/qtsupport/qtversionfactory.h
+++ b/src/plugins/qtsupport/qtversionfactory.h
@@ -49,6 +49,8 @@ public:
explicit QtVersionFactory(QObject *parent = 0);
~QtVersionFactory();
+ static const QList<QtVersionFactory *> allQtVersionFactories();
+
virtual bool canRestore(const QString &type) = 0;
virtual BaseQtVersion *restore(const QString &type, const QVariantMap &data) = 0;