aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/silversearcher
diff options
context:
space:
mode:
authorJarek Kobus <jaroslaw.kobus@qt.io>2023-05-31 23:44:43 +0200
committerJarek Kobus <jaroslaw.kobus@qt.io>2023-06-01 09:40:58 +0000
commit1e09ac087a635f8207399d6851767214b75e0fb4 (patch)
treedb3c1ad1f6bc00609e2c295783b8d2e3b6fc5065 /src/plugins/silversearcher
parenta17fe325c08673787b10a9cb7622a0ef3262ff1d (diff)
SilverSearcher: Limit the number of calls to nextLine()
It's a preparation step for the incremental parsing. Change-Id: I98268abd6d3e0210f218663a6c2bb701c3bfc070 Reviewed-by: Orgad Shaneh <orgads@gmail.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Diffstat (limited to 'src/plugins/silversearcher')
-rw-r--r--src/plugins/silversearcher/silversearcheroutputparser.cpp7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/plugins/silversearcher/silversearcheroutputparser.cpp b/src/plugins/silversearcher/silversearcheroutputparser.cpp
index 65d773d0c68..e9e16fa077e 100644
--- a/src/plugins/silversearcher/silversearcheroutputparser.cpp
+++ b/src/plugins/silversearcher/silversearcheroutputparser.cpp
@@ -112,8 +112,10 @@ SearchResultItems parse(const QString &output, const std::optional<QRegularExpre
const FilePath filePath = FilePath::fromPathPart(filePathLine.mid(1));
- QStringView hitLine = nextLine(&remainingOutput);
- while (!hitLine.isEmpty()) {
+ while (true) {
+ QStringView hitLine = nextLine(&remainingOutput);
+ if (hitLine.isEmpty())
+ break;
int lineNumber = -1;
if (!parseLineNumber(&hitLine, &lineNumber))
break;
@@ -133,7 +135,6 @@ SearchResultItems parse(const QString &output, const std::optional<QRegularExpre
: QVariant());
items.append(item);
}
- hitLine = nextLine(&remainingOutput);
}
}
return items;