diff options
author | Jarek Kobus <jaroslaw.kobus@theqtcompany.com> | 2015-06-18 15:23:57 +0200 |
---|---|---|
committer | Jarek Kobus <jaroslaw.kobus@theqtcompany.com> | 2015-06-18 14:09:21 +0000 |
commit | 23880f77de68597c666abe880fef92baddeaa183 (patch) | |
tree | 0fac536604a48c7fc122c187cacefb92075aeefb /src/plugins/subversion | |
parent | 9ba80c699cb4c0ce42deb6d40c5591e1f6a61032 (diff) |
SubversionPlugin: Introduce member initialization.
Change-Id: Ib242ebdadf858cf64dbce8799699f024d7368204
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
Diffstat (limited to 'src/plugins/subversion')
-rw-r--r-- | src/plugins/subversion/subversionclient.cpp | 5 | ||||
-rw-r--r-- | src/plugins/subversion/subversionplugin.cpp | 28 | ||||
-rw-r--r-- | src/plugins/subversion/subversionplugin.h | 57 |
3 files changed, 31 insertions, 59 deletions
diff --git a/src/plugins/subversion/subversionclient.cpp b/src/plugins/subversion/subversionclient.cpp index 8bfa03249a..75b1d69c69 100644 --- a/src/plugins/subversion/subversionclient.cpp +++ b/src/plugins/subversion/subversionclient.cpp @@ -180,14 +180,13 @@ private: const SubversionClient *m_client; QString m_workingDirectory; QStringList m_filesList; - int m_changeNumber; + int m_changeNumber = 0; }; DiffController::DiffController(IDocument *document, const SubversionClient *client, const QString &directory) : DiffEditorController(document), m_client(client), - m_workingDirectory(directory), - m_changeNumber(0) + m_workingDirectory(directory) { forceContextLineCount(3); // SVN can not change that when using internal diff } diff --git a/src/plugins/subversion/subversionplugin.cpp b/src/plugins/subversion/subversionplugin.cpp index aa97766d8c..2eadd77843 100644 --- a/src/plugins/subversion/subversionplugin.cpp +++ b/src/plugins/subversion/subversionplugin.cpp @@ -175,33 +175,7 @@ static inline QStringList svnDirectories() SubversionPlugin *SubversionPlugin::m_subversionPluginInstance = 0; SubversionPlugin::SubversionPlugin() : - m_svnDirectories(svnDirectories()), - m_commandLocator(0), - m_addAction(0), - m_deleteAction(0), - m_revertAction(0), - m_diffProjectAction(0), - m_diffCurrentAction(0), - m_logProjectAction(0), - m_logRepositoryAction(0), - m_commitAllAction(0), - m_revertRepositoryAction(0), - m_diffRepositoryAction(0), - m_statusRepositoryAction(0), - m_updateRepositoryAction(0), - m_commitCurrentAction(0), - m_filelogCurrentAction(0), - m_annotateCurrentAction(0), - m_statusProjectAction(0), - m_updateProjectAction(0), - m_commitProjectAction(0), - m_describeAction(0), - m_submitCurrentLogAction(0), - m_submitDiffAction(0), - m_submitUndoAction(0), - m_submitRedoAction(0), - m_menuAction(0), - m_submitActionTriggered(false) + m_svnDirectories(svnDirectories()) { } diff --git a/src/plugins/subversion/subversionplugin.h b/src/plugins/subversion/subversionplugin.h index 8d7c98eaf1..4ed1051a7e 100644 --- a/src/plugins/subversion/subversionplugin.h +++ b/src/plugins/subversion/subversionplugin.h @@ -57,8 +57,7 @@ class SubversionClient; struct SubversionResponse { - SubversionResponse() : error(false) {} - bool error; + bool error = false; QString stdOut; QString stdErr; QString message; @@ -153,33 +152,33 @@ private: QString m_commitMessageFileName; QString m_commitRepository; - Core::CommandLocator *m_commandLocator; - Utils::ParameterAction *m_addAction; - Utils::ParameterAction *m_deleteAction; - Utils::ParameterAction *m_revertAction; - Utils::ParameterAction *m_diffProjectAction; - Utils::ParameterAction *m_diffCurrentAction; - Utils::ParameterAction *m_logProjectAction; - QAction *m_logRepositoryAction; - QAction *m_commitAllAction; - QAction *m_revertRepositoryAction; - QAction *m_diffRepositoryAction; - QAction *m_statusRepositoryAction; - QAction *m_updateRepositoryAction; - Utils::ParameterAction *m_commitCurrentAction; - Utils::ParameterAction *m_filelogCurrentAction; - Utils::ParameterAction *m_annotateCurrentAction; - Utils::ParameterAction *m_statusProjectAction; - Utils::ParameterAction *m_updateProjectAction; - Utils::ParameterAction *m_commitProjectAction; - QAction *m_describeAction; - - QAction *m_submitCurrentLogAction; - QAction *m_submitDiffAction; - QAction *m_submitUndoAction; - QAction *m_submitRedoAction; - QAction *m_menuAction; - bool m_submitActionTriggered; + Core::CommandLocator *m_commandLocator = nullptr; + Utils::ParameterAction *m_addAction = nullptr; + Utils::ParameterAction *m_deleteAction = nullptr; + Utils::ParameterAction *m_revertAction = nullptr; + Utils::ParameterAction *m_diffProjectAction = nullptr; + Utils::ParameterAction *m_diffCurrentAction = nullptr; + Utils::ParameterAction *m_logProjectAction = nullptr; + QAction *m_logRepositoryAction = nullptr; + QAction *m_commitAllAction = nullptr; + QAction *m_revertRepositoryAction = nullptr; + QAction *m_diffRepositoryAction = nullptr; + QAction *m_statusRepositoryAction = nullptr; + QAction *m_updateRepositoryAction = nullptr; + Utils::ParameterAction *m_commitCurrentAction = nullptr; + Utils::ParameterAction *m_filelogCurrentAction = nullptr; + Utils::ParameterAction *m_annotateCurrentAction = nullptr; + Utils::ParameterAction *m_statusProjectAction = nullptr; + Utils::ParameterAction *m_updateProjectAction = nullptr; + Utils::ParameterAction *m_commitProjectAction = nullptr; + QAction *m_describeAction = nullptr; + + QAction *m_submitCurrentLogAction = nullptr; + QAction *m_submitDiffAction = nullptr; + QAction *m_submitUndoAction = nullptr; + QAction *m_submitRedoAction = nullptr; + QAction *m_menuAction = nullptr; + bool m_submitActionTriggered = false; static SubversionPlugin *m_subversionPluginInstance; }; |