diff options
| author | Jarek Kobus <jaroslaw.kobus@theqtcompany.com> | 2015-06-16 15:24:42 +0200 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@theqtcompany.com> | 2015-06-17 17:00:56 +0000 |
| commit | 684267179e3deb4de8af7a4b8b01948dc6676a79 (patch) | |
| tree | e134897bf6d62b5175480c96e6b4aea12c8da0d8 /src/plugins/subversion | |
| parent | 8131aea4f9301fd050a9dfc6141cde8205798b56 (diff) | |
Properly delete plugins dependent on failed plugin
Init all class member pointers to NULL.
This fixes possible crash on exit when dependent
plugin was not loaded (e.g. TextEditor was missing).
In this case plugin's constructor gets called,
initialize() method is _not_ called
and destructor gets called -> crash.
Properly delete dependent plugins on
a plugin which failed to initialize properly.
Fix labels of deleted plugins inside an error dialog
after pressing "Error Details" from "Installed Plugins"
dialog.
Change-Id: Iddc029a0f07dcba2501d734d142fb0e69e9383d3
Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
Diffstat (limited to 'src/plugins/subversion')
| -rw-r--r-- | src/plugins/subversion/subversionplugin.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/subversion/subversionplugin.h b/src/plugins/subversion/subversionplugin.h index dcc16c3f71..8d7c98eaf1 100644 --- a/src/plugins/subversion/subversionplugin.h +++ b/src/plugins/subversion/subversionplugin.h @@ -149,7 +149,7 @@ private: const QStringList m_svnDirectories; - SubversionClient *m_client; + SubversionClient *m_client = nullptr; QString m_commitMessageFileName; QString m_commitRepository; |