BaseFileFind/FindInFiles: Clean up enabled / valid state handling

IFindFilter:  Separate enabledChanged and validChanged
SearchEngine: Add enabledChanged
GitGrep:      Enable widget based on enabled state
FindInFiles:  Update validity on search engine enabledChanged instead of
              hardcoding it to when the search path changed

Change-Id: I0c684423b871a3a4f1f164574f42e23b64cf9da0
Reviewed-by: David Schulz <david.schulz@qt.io>

1 files changed, 17 insertions, 3 deletions

diff --git a/src/plugins/texteditor/basefilefind.h b/src/plugins/texteditor/basefilefind.h
index a681010225d..9ea93a85b6e 100644
--- a/src/plugins/texteditor/basefilefind.h
+++ b/src/plugins/texteditor/basefilefind.h
@@ -48,7 +48,10 @@ class SearchResultItem;
 
 namespace TextEditor {
 
-namespace Internal { class BaseFileFindPrivate; }
+namespace Internal {
+class BaseFileFindPrivate;
+class SearchEnginePrivate;
+} // Internal
 
 class TEXTEDITOR_EXPORT FileFindParameters
 {
@@ -65,12 +68,13 @@ class BaseFileFind;
 
 class TEXTEDITOR_EXPORT SearchEngine : public QObject
 {
+    Q_OBJECT
 public:
-    virtual ~SearchEngine() {}
+    SearchEngine();
+    ~SearchEngine();
     virtual QString title() const = 0;
     virtual QString toolTip() const = 0; // add %1 placeholder where the find flags should be put
     virtual QWidget *widget() const = 0;
-    virtual bool isEnabled() const = 0;
     virtual QVariant parameters() const = 0;
     virtual void readSettings(QSettings *settings) = 0;
     virtual void writeSettings(QSettings *settings) const = 0;
@@ -78,7 +82,14 @@ public:
             const FileFindParameters &parameters, BaseFileFind *baseFileFind) = 0;
     virtual Core::IEditor *openEditor(const Core::SearchResultItem &item,
                                       const FileFindParameters &parameters) = 0;
+    bool isEnabled() const;
+    void setEnabled(bool enabled);
+
+signals:
+    void enabledChanged(bool enabled);
 
+private:
+    Internal::SearchEnginePrivate *d;
 };
 
 class TEXTEDITOR_EXPORT BaseFileFind : public Core::IFindFilter
@@ -122,6 +133,9 @@ protected:
     void setCurrentSearchEngine(int index);
     virtual void syncSearchEngineCombo(int /*selectedSearchEngineIndex*/) {}
 
+signals:
+    void currentSearchEngineChanged();
+
 private:
     void displayResult(int index);
     void searchFinished();