aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/texteditor/codeassist
diff options
context:
space:
mode:
authorDavid Schulz <david.schulz@qt.io>2022-11-07 12:02:07 +0100
committerDavid Schulz <david.schulz@qt.io>2022-11-08 12:07:56 +0000
commit08002c6278383363838d36fba05946f53e5152f7 (patch)
treeb064923b18a398f8ec0f9154289c42b869c069bd /src/plugins/texteditor/codeassist
parent3c6435387b5219e056592efc21bb5c09eaa432ce (diff)
Editor: delete assist interface in lsp/clangd support
The complete memory management in the code assistant needs an overhaul. For now just delete or at least track the assist interface with scoped pointers. Fixes: QTCREATORBUG-28408 Change-Id: I0bd4cfaa36a660b6fd5bb467af3b13414ed76e63 Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io> Reviewed-by: Christian Kandeler <christian.kandeler@qt.io> Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Diffstat (limited to 'src/plugins/texteditor/codeassist')
-rw-r--r--src/plugins/texteditor/codeassist/iassistprocessor.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/texteditor/codeassist/iassistprocessor.h b/src/plugins/texteditor/codeassist/iassistprocessor.h
index 1835b90651..583f3ae973 100644
--- a/src/plugins/texteditor/codeassist/iassistprocessor.h
+++ b/src/plugins/texteditor/codeassist/iassistprocessor.h
@@ -19,7 +19,7 @@ public:
virtual ~IAssistProcessor();
virtual IAssistProposal *immediateProposal(const AssistInterface *) { return nullptr; }
- virtual IAssistProposal *perform(const AssistInterface *interface) = 0;
+ virtual IAssistProposal *perform(const AssistInterface *interface) = 0; // takes ownership
void setAsyncProposalAvailable(IAssistProposal *proposal);