diff options
| author | Jarek Kobus <jaroslaw.kobus@qt.io> | 2023-06-28 22:42:22 +0200 |
|---|---|---|
| committer | Jarek Kobus <jaroslaw.kobus@qt.io> | 2023-07-06 18:45:19 +0000 |
| commit | bf09d179928c29983b4d18d1eef506615ac24234 (patch) | |
| tree | e46ac8d29d5dd0f419ec33a607b91ab0bf673894 /src/plugins/texteditor/findinopenfiles.cpp | |
| parent | cf7a41e963d8763640eb0ff76538c7e30dfff784 (diff) | |
BaseFileFind: Replace additionalParameters() with searchDir()
The FileFindParameters::additionalParameters,
holding QVariant, was ambiguous. Since GitGrep and
SilverSearcher need a search directory input
unconditionally, replace the additionalParameters field
with searchDir of FilePath type. For Internal
search engine, this field isn't used - the searchDir
is already passed in FindInFiles::fileContainerProvider()
with lambda capture; for other BaseFileFind subclasses,
not combined with non-Internal search engine, the field
isn't used anyway.
This change closes the chain of patches to eliminate
the usage of ambiguous QVariant type inside FileFindParameters.
Change-Id: Icddd1cfe46e86ea892221862d9d267f9c9fa173c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Diffstat (limited to 'src/plugins/texteditor/findinopenfiles.cpp')
| -rw-r--r-- | src/plugins/texteditor/findinopenfiles.cpp | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/plugins/texteditor/findinopenfiles.cpp b/src/plugins/texteditor/findinopenfiles.cpp index 6b3e7dbe9c..2f2ee8de1d 100644 --- a/src/plugins/texteditor/findinopenfiles.cpp +++ b/src/plugins/texteditor/findinopenfiles.cpp @@ -57,11 +57,6 @@ FileContainerProvider FindInOpenFiles::fileContainerProvider() const }; } -QVariant FindInOpenFiles::additionalParameters() const -{ - return {}; -} - QString FindInOpenFiles::label() const { return Tr::tr("Open documents:"); |