diff options
| author | Eike Ziller <eike.ziller@qt.io> | 2020-06-02 09:10:40 +0200 |
|---|---|---|
| committer | Eike Ziller <eike.ziller@qt.io> | 2020-06-02 11:44:53 +0000 |
| commit | 5b364de1685e5bee5953e23da2552b5db4455a74 (patch) | |
| tree | 13f505553880048143feea6678dbd09e31558599 /src/plugins/texteditor/refactoringchanges.cpp | |
| parent | 26d46fc19dccb3b599dcd24f2a3701b7c4e25d2b (diff) | |
Use dialogParent() instead of mainWindow()
There are very few reasons to use mainWindow() directly.
Especially for modal dialogs, using dialogParent() is important, since
that guarantees the stacking order in case of other dialogs currently
being open.
Change-Id: I7ad2c23c5034b43195eb35cfe405932a7ea003e6
Reviewed-by: hjk <hjk@qt.io>
Diffstat (limited to 'src/plugins/texteditor/refactoringchanges.cpp')
| -rw-r--r-- | src/plugins/texteditor/refactoringchanges.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/texteditor/refactoringchanges.cpp b/src/plugins/texteditor/refactoringchanges.cpp index 9e91463349..cc8166e0fe 100644 --- a/src/plugins/texteditor/refactoringchanges.cpp +++ b/src/plugins/texteditor/refactoringchanges.cpp @@ -312,7 +312,7 @@ bool RefactoringFile::apply() { // test file permissions if (!QFileInfo(fileName()).isWritable()) { - ReadOnlyFilesDialog roDialog(FilePath::fromString(fileName()), ICore::mainWindow()); + ReadOnlyFilesDialog roDialog(FilePath::fromString(fileName()), ICore::dialogParent()); const QString &failDetailText = QApplication::translate("RefactoringFile::apply", "Refactoring cannot be applied."); roDialog.setShowFailWarning(true, failDetailText); |