diff options
| author | Christian Kandeler <christian.kandeler@qt.io> | 2021-05-07 16:10:07 +0200 |
|---|---|---|
| committer | Christian Kandeler <christian.kandeler@qt.io> | 2021-08-13 12:35:49 +0000 |
| commit | 33108795d6b2dd1e91942efb3c1c27ad23342295 (patch) | |
| tree | 084d21ac56db3c55c84f242acc8400f2e68cd81c /src/plugins/todo | |
| parent | 3143ba79e3d954e006f261cc0a535724a4fdc08a (diff) | |
CppTools: Turn some classes into pure value types
ProjectInfo, ProjectPart and ProjectUpdateInfo used to carry pointers
to Project and/or Toolchain, even though they were used in contexts
where these pointers were either unsafe to access or not guaranteed to
be valid anymore, which made their use difficult and error-prone.
We turn these classes into pure value types by copying in all relevant
information before the first async operation takes place.
Fixes: QTCREATORBUG-25678
Change-Id: I1914b0dbda6c7dfba6c95e5e92f2d69977755590
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Diffstat (limited to 'src/plugins/todo')
| -rw-r--r-- | src/plugins/todo/cpptodoitemsscanner.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/plugins/todo/cpptodoitemsscanner.cpp b/src/plugins/todo/cpptodoitemsscanner.cpp index 8fa99722743..2bcdb35499b 100644 --- a/src/plugins/todo/cpptodoitemsscanner.cpp +++ b/src/plugins/todo/cpptodoitemsscanner.cpp @@ -58,9 +58,8 @@ void CppTodoItemsScanner::scannerParamsChanged() CppTools::CppModelManager *modelManager = CppTools::CppModelManager::instance(); QSet<QString> filesToBeUpdated; - foreach (const CppTools::ProjectInfo &info, modelManager->projectInfos()) - filesToBeUpdated.unite(Utils::transform<QSet>(info.project().data()->files(ProjectExplorer::Project::SourceFiles), - &Utils::FilePath::toString)); + foreach (const CppTools::ProjectInfo::Ptr &info, modelManager->projectInfos()) + filesToBeUpdated.unite(info->sourceFiles()); modelManager->updateSourceFiles(filesToBeUpdated); } |